Re: [RFC PATCH 11/13] mm/vas: Introduce VAS segments - shareable address space regions

Matthew Wilcox
2017-03-13T22:27:58Z

On Mon, Mar 13, 2017 at 03:14:13PM -0700, Till Smejkal wrote:
> +/**
> + * Create a new VAS segment.
> + *
> + * @param[in] name: The name of the new VAS segment.
> + * @param[in] start: The address where the VAS segment begins.
> + * @param[in] end: The address where the VAS segment ends.
> + * @param[in] mode: The access rights for the VAS segment.
> + *
> + * @returns: The VAS segment ID on success, -ERRNO otherwise.
> + **/

Please follow the kernel-doc conventions, as described in
Documentation/doc-guide/kernel-doc.rst. Also, function documentation
goes with the implementation, not the declaration.

> +/**
> + * Get ID of the VAS segment belonging to a given name.
> + *
> + * @param[in] name: The name of the VAS segment for which the ID
> + * should be returned.
> + *
> + * @returns: The VAS segment ID on success, -ERRNO
> + * otherwise.
> + **/
> +extern int vas_seg_find(const char *name);

So ... segments have names, and IDs ... and access permissions ...
Why isn't this a special purpose filesystem?