Re: [PATCH v3 3/8] nand: spi: add basic blocks for infrastructure

Arnaud Mouiche
2017-03-17T10:20:41Z

[...]
> +/*
> + * spinand_detect - [SPI NAND Interface] detect the SPI NAND device
> + * @chip: SPI NAND device structure
> + */
> +int spinand_detect(struct spinand_device *chip)
> +{
> + struct nand_device *nand = &chip->base;
> + u8 raw_id[SPINAND_MAX_ID_LEN] = {0};
> + u8 id[SPINAND_MAX_ID_LEN] = {0};
> + int ret;
> +
> + spinand_reset(chip);
> + spinand_read_id(chip, raw_id);
> + ret = spinand_manufacturer_detect(chip, raw_id, id);
> + if (ret)

Would be great to return an error or warning message when the raw_id
doesn't match any known manufacturer, or when the manufacturer doesn't
know about this device.
something like:

pr_err("SPI NAND: unknown raw ID %*phN\n", SPINAND_MAX_ID_LEN, raw_id);

> + return ret;
> +
> + spinand_fill_id(chip, id);
> +
> + pr_info("SPI NAND: %s is found.\n", chip->name);
> + pr_info("Manufacturer ID: 0x%02x, Chip ID: 0x%02x\n",
> + spinand_get_mfr_id(chip), spinand_get_dev_id(chip));
> + pr_info("%d MiB, block size: %d KiB, page size: %d, OOB size: %d\n",
> + (int)(nand_size(nand) >> 20), nand_eraseblock_size(nand) >> 10,
> + nand_page_size(nand), nand_per_page_oobsize(nand));
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(spinand_detect);
> +