Re: [PATCH 02/13] mtd: nand: fsmc: rework fsmc_nand_setup() to use ->setup_data_interface()

Thomas Petazzoni
2017-03-22T22:39:41Z

Hello,

On Wed, 22 Mar 2017 23:23:33 +0100, Boris Brezillon wrote:

> > So what do you suggest to keep the compatibility with the existing DT
> > binding for this NAND controller?
>
> We have 2 choices here:
> 1/ drop the old/static timings config and only rely on the dynamic
> config. This is a bit risky, because we've only tested the new
> timing conversion logic on one board.
> 2/ keep both solutions around until all boards have switched to the new
> solution. In this case, you'll only set the ->setup_data_interface()
> hook if timings are not defined in the DT

What about the "default" timings that are currently hardcoded in the
driver, if no timings are specified in the DT? My patch currently does
the following:

- Use DT timings if provided
- Use NAND timings if provided
- Use "default" timing otherwise

Should we drop the "default" timing thing? If not, how does it fit in
your proposal? Indeed your proposal is simply: if no timings in DT, use
the NAND timings. But my patch does more than that.

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering