* [patch] mtd: nand: hynix: Fix an error code in init
@ 2017-03-22 9:01 Dan Carpenter
2017-03-22 9:53 ` Richard Weinberger
2017-03-23 9:45 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-03-22 9:01 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Cyrille Pitchen, linux-mtd, kernel-janitors
We should be return -ENOMEM instead of success.
Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mtd/nand/nand_hynix.c b/drivers/mtd/nand/nand_hynix.c
index 2a5d0efea498..b12dc7325378 100644
--- a/drivers/mtd/nand/nand_hynix.c
+++ b/drivers/mtd/nand/nand_hynix.c
@@ -270,8 +270,10 @@ static int hynix_mlc_1xnm_rr_init(struct nand_chip *chip,
goto out;
rr = kzalloc(sizeof(*rr) + (nregs * nmodes), GFP_KERNEL);
- if (!rr)
+ if (!rr) {
+ ret = -ENOMEM;
goto out;
+ }
for (i = 0; i < nmodes; i++) {
for (j = 0; j < nregs; j++) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] mtd: nand: hynix: Fix an error code in init
2017-03-22 9:01 [patch] mtd: nand: hynix: Fix an error code in init Dan Carpenter
@ 2017-03-22 9:53 ` Richard Weinberger
2017-03-23 9:45 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2017-03-22 9:53 UTC (permalink / raw)
To: Dan Carpenter, Boris Brezillon
Cc: David Woodhouse, Brian Norris, Marek Vasut, Cyrille Pitchen,
linux-mtd, kernel-janitors
Am 22.03.2017 um 10:01 schrieb Dan Carpenter:
> We should be return -ENOMEM instead of success.
>
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/mtd/nand/nand_hynix.c b/drivers/mtd/nand/nand_hynix.c
> index 2a5d0efea498..b12dc7325378 100644
> --- a/drivers/mtd/nand/nand_hynix.c
> +++ b/drivers/mtd/nand/nand_hynix.c
> @@ -270,8 +270,10 @@ static int hynix_mlc_1xnm_rr_init(struct nand_chip *chip,
> goto out;
>
> rr = kzalloc(sizeof(*rr) + (nregs * nmodes), GFP_KERNEL);
> - if (!rr)
> + if (!rr) {
> + ret = -ENOMEM;
> goto out;
> + }
>
> for (i = 0; i < nmodes; i++) {
> for (j = 0; j < nregs; j++) {
>
Reviewed-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] mtd: nand: hynix: Fix an error code in init
2017-03-22 9:01 [patch] mtd: nand: hynix: Fix an error code in init Dan Carpenter
2017-03-22 9:53 ` Richard Weinberger
@ 2017-03-23 9:45 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-03-23 9:45 UTC (permalink / raw)
To: Dan Carpenter
Cc: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Cyrille Pitchen, linux-mtd, kernel-janitors
On Wed, 22 Mar 2017 12:01:45 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should be return -ENOMEM instead of success.
>
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
Thanks,
Boris
>
> diff --git a/drivers/mtd/nand/nand_hynix.c b/drivers/mtd/nand/nand_hynix.c
> index 2a5d0efea498..b12dc7325378 100644
> --- a/drivers/mtd/nand/nand_hynix.c
> +++ b/drivers/mtd/nand/nand_hynix.c
> @@ -270,8 +270,10 @@ static int hynix_mlc_1xnm_rr_init(struct nand_chip *chip,
> goto out;
>
> rr = kzalloc(sizeof(*rr) + (nregs * nmodes), GFP_KERNEL);
> - if (!rr)
> + if (!rr) {
> + ret = -ENOMEM;
> goto out;
> + }
>
> for (i = 0; i < nmodes; i++) {
> for (j = 0; j < nregs; j++) {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-23 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-22 9:01 [patch] mtd: nand: hynix: Fix an error code in init Dan Carpenter
2017-03-22 9:53 ` Richard Weinberger
2017-03-23 9:45 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox