linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ubifs: Don't block RENAME_WHITEOUT flag in rename
@ 2017-03-29 15:12 Jesper Nilsson
  0 siblings, 0 replies; only message in thread
From: Jesper Nilsson @ 2017-03-29 15:12 UTC (permalink / raw)
  To: Richard Weinberger, Artem Bityutskiy, Adrian Hunter, linux-mtd,
	linux-kernel

The test does not allow the valid flag RENAME_WHITEOUT
and in fact, the calling function of do_rename already tests
the flags, so the test is unnecessary, allowing us to drop
it completely.

With this patch RENAME_WHITEOUT for overlayfs on ubifs works
as intended.

Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
 fs/ubifs/dir.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 30825d88..01ab543 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -1316,9 +1316,6 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,
 	unsigned int uninitialized_var(saved_nlink);
 	struct fscrypt_name old_nm, new_nm;
 
-	if (flags & ~RENAME_NOREPLACE)
-		return -EINVAL;
-
 	/*
 	 * Budget request settings: deletion direntry, new direntry, removing
 	 * the old inode, and changing old and new parent directory inodes.
-- 
2.1.4


/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-29 15:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-29 15:12 [PATCH] ubifs: Don't block RENAME_WHITEOUT flag in rename Jesper Nilsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).