From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Richard Weinberger" <richard@nod.at>,
"Cyrille Pitchen" <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] mtd: use dev_of_node helper in mtd_get_of_node
Date: Fri, 31 Mar 2017 11:49:50 +0200 [thread overview]
Message-ID: <20170331114950.726c9cb7@bbrezillon> (raw)
In-Reply-To: <20170331091148.19816-1-zajec5@gmail.com>
On Fri, 31 Mar 2017 11:11:48 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This allows better compile-time optimizations with CONFIG_OF disabled.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Not sure we care about such micro-optimizations, but it shouldn't hurst
so,
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> include/linux/mtd/mtd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index eebdc63cf6af..f8db5b2e4028 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -393,7 +393,7 @@ static inline void mtd_set_of_node(struct mtd_info *mtd,
>
> static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
> {
> - return mtd->dev.of_node;
> + return dev_of_node(&mtd->dev);
> }
>
> static inline int mtd_oobavail(struct mtd_info *mtd, struct mtd_oob_ops *ops)
next prev parent reply other threads:[~2017-03-31 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 9:11 [PATCH] mtd: use dev_of_node helper in mtd_get_of_node Rafał Miłecki
2017-03-31 9:49 ` Boris Brezillon [this message]
2017-04-19 18:39 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331114950.726c9cb7@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox