From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cxqrc-0006Lt-CX for linux-mtd@lists.infradead.org; Tue, 11 Apr 2017 08:09:26 +0000 Date: Tue, 11 Apr 2017 10:09:02 +0200 From: Boris Brezillon To: Dan Carpenter Cc: Wenyou Yang , Josh Wu , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] mtd: nand: Fix a couple error codes Message-ID: <20170411100902.072b812f@bbrezillon> In-Reply-To: <20170410070943.GA4366@mwanda> References: <20170404081545.GA25533@mwanda> <20170409163322.3da06acd@bbrezillon> <20170410070943.GA4366@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 10 Apr 2017 10:09:43 +0300 Dan Carpenter wrote: > On Sun, Apr 09, 2017 at 04:33:22PM +0200, Boris Brezillon wrote: > > Hi Dan, > > > > On Tue, 4 Apr 2017 11:15:46 +0300 > > Dan Carpenter wrote: > > > > > We accidentally return 1 on error instead of proper error codes. > > > > These bugs have not reached Linus' tree yet and I'll have to force push > > my nand/next branch because of regressions introduced by other patches > > (not related to the Atmel NAND driver rework). Do you mind if I squash > > the changes in the original commit? > > > > No problem. I'm lobying for a Fixes-from: tag for this, (which would > not cover style issues), but it's not an official tag yet. Never mind. Another bug as been reported/fixed in the same driver, so I'll just pick your patch as is instead of merging the changes in the initial commit. Thanks, Boris