From: "Rafał Miłecki" <zajec5@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH V4 3/3] mtd: physmap_of: drop duplicated support for linux, part-probe property
Date: Mon, 17 Apr 2017 20:28:53 +0200 [thread overview]
Message-ID: <20170417182853.24281-3-zajec5@gmail.com> (raw)
In-Reply-To: <20170417182853.24281-1-zajec5@gmail.com>
From: Rafał Miłecki <rafal@milecki.pl>
Now support for linux,part-probe has been added to the MTD core there is
no need to duplicate support for it in physmap_of.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
drivers/mtd/maps/physmap_of.c | 46 +------------------------------------------
1 file changed, 1 insertion(+), 45 deletions(-)
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index 14e8909c9955..49dbb7235848 100644
--- a/drivers/mtd/maps/physmap_of.c
+++ b/drivers/mtd/maps/physmap_of.c
@@ -114,47 +114,9 @@ static struct mtd_info *obsolete_probe(struct platform_device *dev,
static const char * const part_probe_types_def[] = {
"cmdlinepart", "RedBoot", "ofpart", "ofoldpart", NULL };
-static const char * const *of_get_probes(struct device_node *dp)
-{
- const char *cp;
- int cplen;
- unsigned int l;
- unsigned int count;
- const char **res;
-
- cp = of_get_property(dp, "linux,part-probe", &cplen);
- if (cp == NULL)
- return part_probe_types_def;
-
- count = 0;
- for (l = 0; l != cplen; l++)
- if (cp[l] == 0)
- count++;
-
- res = kzalloc((count + 1)*sizeof(*res), GFP_KERNEL);
- if (!res)
- return NULL;
- count = 0;
- while (cplen > 0) {
- res[count] = cp;
- l = strlen(cp) + 1;
- cp += l;
- cplen -= l;
- count++;
- }
- return res;
-}
-
-static void of_free_probes(const char * const *probes)
-{
- if (probes != part_probe_types_def)
- kfree(probes);
-}
-
static const struct of_device_id of_flash_match[];
static int of_flash_probe(struct platform_device *dev)
{
- const char * const *part_probe_types;
const struct of_device_id *match;
struct device_node *dp = dev->dev.of_node;
struct resource res;
@@ -320,14 +282,8 @@ static int of_flash_probe(struct platform_device *dev)
info->cmtd->dev.parent = &dev->dev;
mtd_set_of_node(info->cmtd, dp);
- part_probe_types = of_get_probes(dp);
- if (!part_probe_types) {
- err = -ENOMEM;
- goto err_out;
- }
- mtd_device_parse_register(info->cmtd, part_probe_types, NULL,
+ mtd_device_parse_register(info->cmtd, part_probe_types_def, NULL,
NULL, 0);
- of_free_probes(part_probe_types);
kfree(mtd_list);
--
2.11.0
next prev parent reply other threads:[~2017-04-17 18:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:40 [PATCH V3 1/3] dt-bindings: mtd: document linux,part-probe property Rafał Miłecki
2017-03-31 11:40 ` [PATCH V3 2/3] mtd: add core code reading DT specified part probes Rafał Miłecki
2017-04-09 11:04 ` Boris Brezillon
2017-04-09 13:28 ` Boris Brezillon
2017-03-31 11:40 ` [PATCH V3 3/3] mtd: physmap_of: drop duplicated support for linux, part-probe property Rafał Miłecki
2017-04-09 11:04 ` [PATCH V3 3/3] mtd: physmap_of: drop duplicated support for linux,part-probe property Boris Brezillon
2017-04-03 16:40 ` [PATCH V3 1/3] dt-bindings: mtd: document " Rob Herring
2017-04-09 10:40 ` Boris Brezillon
2017-04-17 18:28 ` [PATCH V4 " Rafał Miłecki
2017-04-17 18:28 ` [PATCH V4 2/3] mtd: add core code reading DT specified part probes Rafał Miłecki
2017-04-17 19:31 ` Boris Brezillon
2017-04-17 18:28 ` Rafał Miłecki [this message]
2017-04-17 19:47 ` [PATCH V5 1/3] dt-bindings: mtd: document linux,part-probe property Rafał Miłecki
2017-04-17 19:47 ` [PATCH V5 2/3] mtd: add core code reading DT specified part probes Rafał Miłecki
2017-04-17 19:47 ` [PATCH V5 3/3] mtd: physmap_of: drop duplicated support for linux, part-probe property Rafał Miłecki
2017-04-19 20:37 ` [PATCH V5 1/3] dt-bindings: mtd: document linux,part-probe property Brian Norris
2017-04-19 20:55 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417182853.24281-3-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox