public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: linux-mtd@lists.infradead.org
Subject: SW ECC - double bit flip detection on old NAND devices
Date: Fri, 5 May 2017 15:14:25 +0200	[thread overview]
Message-ID: <20170505151425.4350ea69@jawa> (raw)

Dear All,

I've a problem with pretty old Flash NAND memory (Samsung 128Mx8) [1]

It doesn't support On-Chip ECC - one needs to calculate ECC manually.

The Yaffs2 FS (for this version) uses "1bit correction
ECC" (yaffs_ecc.c). It calculates ECC for 256 bytes -> we have got 22
bits for ECC (rounded up to 3 bytes).

For 2048 bytes page we do have 8 such ECC blocks -> 24 ECC bytes in
total in OOB.

This code (as noted in yaffs_ecc.* header) is able to correct one
single bit flip.

I've also looked into Linux kernel code for SW ECC calculation:

http://elixir.free-electrons.com/linux/latest/source/drivers/mtd/nand/nand_ecc.c#L523

And here it is also explicitly said that we can correct one bit in such
chunk.

Please correct me if I'm wrong but when we have two bit-flips in such
256 bytes chunk, the ECC will be still correct and such obviously
broken page will not be "retired".

What one can do to prevent such situation? 

My idea, if the above holds, would be to implement better ECC scheme as
proposed in "Error Correction Code (ECC) in Micron" doc [2].

Maybe somebody knows better/simpler solution?


Side note: newer NANDs support On-Chip ECC with algorithms allowing
correction of up to 4 bits in 512B chunks of data.


[1] -
http://www.sst-ic.com/File/Seriea/PDF/100923163334f47b2ce6-13b7-43d0-9b8c-ec1c75ca2c6f.pdf
[2] -
https://www.micron.com/~/media/documents/products/technical-note/nand-flash/tn2963_ecc_in_slc_nand.pdf

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

             reply	other threads:[~2017-05-05 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 13:14 Lukasz Majewski [this message]
2017-05-07 13:53 ` SW ECC - double bit flip detection on old NAND devices Richard Weinberger
2017-05-07 20:24   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170505151425.4350ea69@jawa \
    --to=lukma@denx.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox