* [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static
@ 2017-05-04 12:11 Colin King
2017-05-04 14:08 ` Boris Brezillon
2017-05-15 20:45 ` Boris Brezillon
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2017-05-04 12:11 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen, linux-mtd
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
nand_ooblayout_lp_hamming_ops can be made static as it does not need to be
in global scope.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/nand/nand_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index d474378ed810..d3a735012b81 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section,
return 0;
}
-const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
+static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
.ecc = nand_ooblayout_ecc_lp_hamming,
.free = nand_ooblayout_free_lp_hamming,
};
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static
2017-05-04 12:11 [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static Colin King
@ 2017-05-04 14:08 ` Boris Brezillon
2017-05-11 18:35 ` Brian Norris
2017-05-15 20:45 ` Boris Brezillon
1 sibling, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2017-05-04 14:08 UTC (permalink / raw)
To: Colin King
Cc: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Cyrille Pitchen, linux-mtd, kernel-janitors, linux-kernel
On Thu, 4 May 2017 13:11:00 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> nand_ooblayout_lp_hamming_ops can be made static as it does not need to be
> in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Brian, feel free to apply this patch directly if you want, otherwise,
I'll queue it for 4.13.
> ---
> drivers/mtd/nand/nand_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index d474378ed810..d3a735012b81 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section,
> return 0;
> }
>
> -const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
> +static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
> .ecc = nand_ooblayout_ecc_lp_hamming,
> .free = nand_ooblayout_free_lp_hamming,
> };
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static
2017-05-04 14:08 ` Boris Brezillon
@ 2017-05-11 18:35 ` Brian Norris
0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2017-05-11 18:35 UTC (permalink / raw)
To: Boris Brezillon
Cc: Colin King, Richard Weinberger, David Woodhouse, Marek Vasut,
Cyrille Pitchen, linux-mtd, kernel-janitors, linux-kernel
On Thu, May 04, 2017 at 04:08:13PM +0200, Boris Brezillon wrote:
> On Thu, 4 May 2017 13:11:00 +0100
> Colin King <colin.king@canonical.com> wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > nand_ooblayout_lp_hamming_ops can be made static as it does not need to be
> > in global scope.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Brian, feel free to apply this patch directly if you want, otherwise,
> I'll queue it for 4.13.
Eh, queue it for 4.13, or in a fixes branch if you want.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static
2017-05-04 12:11 [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static Colin King
2017-05-04 14:08 ` Boris Brezillon
@ 2017-05-15 20:45 ` Boris Brezillon
1 sibling, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2017-05-15 20:45 UTC (permalink / raw)
To: Colin King
Cc: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Cyrille Pitchen, linux-mtd, kernel-janitors, linux-kernel
On Thu, 4 May 2017 13:11:00 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> nand_ooblayout_lp_hamming_ops can be made static as it does not need to be
> in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to nand/fixes.
Thanks,
Boris
> ---
> drivers/mtd/nand/nand_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index d474378ed810..d3a735012b81 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section,
> return 0;
> }
>
> -const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
> +static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
> .ecc = nand_ooblayout_ecc_lp_hamming,
> .free = nand_ooblayout_free_lp_hamming,
> };
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-15 20:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-04 12:11 [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static Colin King
2017-05-04 14:08 ` Boris Brezillon
2017-05-11 18:35 ` Brian Norris
2017-05-15 20:45 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).