From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Scott Wood <oss@buserror.net>
Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>,
linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH] driver: mtd: update struct map_info's swap as per map requirement.
Date: Mon, 15 May 2017 21:01:23 +0200 [thread overview]
Message-ID: <20170515210123.0a9aaeb1@bbrezillon> (raw)
In-Reply-To: <1494869313.29095.5.camel@buserror.net>
On Mon, 15 May 2017 12:28:33 -0500
Scott Wood <oss@buserror.net> wrote:
> On Mon, 2017-05-15 at 10:48 +0200, Boris Brezillon wrote:
> >
> > You can even make this property a string property:
> >
> > if (!of_property_read_string(dp->parent,
> > "cfi-endianness",
> > &endianness)) {
> > if (!strcmp("big", endianness))
> > info->list[i].map.swap = CFI_BIG_ENDIAN;
> > else if (!strcmp("little", endianness))
> > info->list[i].map.swap = CFI_LITTLE_ENDIAN;
> > else if (!strcmp("host", endianness))
> > info->list[i].map.swap = CFI_HOST_ENDIAN;
> > }
>
> Boolean endianness properties are the standard elsewhere -- why should CFI be
> different?
>
> See Documentation/devicetree/bindings/common-properties.txt
Forget this suggestion, I didn't know xxx-endian were standard props. My
first comment still applies though.
prev parent reply other threads:[~2017-05-15 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 7:20 [PATCH] driver: mtd: update struct map_info's swap as per map requirement Prabhakar Kushwaha
2017-05-15 8:48 ` Boris Brezillon
2017-05-15 17:28 ` Scott Wood
2017-05-15 19:01 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515210123.0a9aaeb1@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=oss@buserror.net \
--cc=prabhakar.kushwaha@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox