From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: Re: [PATCH] mtd: nand: tango: Fix incorrect use of SEQIN command
Date: Tue, 16 May 2017 00:30:01 +0200 [thread overview]
Message-ID: <20170516003001.636a9cac@bbrezillon> (raw)
In-Reply-To: <1494886224-20393-1-git-send-email-boris.brezillon@free-electrons.com>
On Tue, 16 May 2017 00:10:24 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> SEQIN is supposed to be used one wants to start programming a page.
^ when one ...
> What we want here is just changing the column within the page, which is
> done with the RNDIN command.
>
Forgot the following tags.
Fixes: 6956e2385a16 ("mtd: nand: add tango NAND flash controller support")
Cc: state@vger.kernel.org
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/tango_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/tango_nand.c b/drivers/mtd/nand/tango_nand.c
> index 05b6e1065203..a2150b15d4c1 100644
> --- a/drivers/mtd/nand/tango_nand.c
> +++ b/drivers/mtd/nand/tango_nand.c
> @@ -332,7 +332,7 @@ static void aux_write(struct nand_chip *chip, const u8 **buf, int len, int *pos)
>
> if (!*buf) {
> /* skip over "len" bytes */
> - chip->cmdfunc(mtd, NAND_CMD_SEQIN, *pos, -1);
> + chip->cmdfunc(mtd, NAND_CMD_RNDIN, *pos, -1);
> } else {
> tango_write_buf(mtd, *buf, len);
> *buf += len;
next prev parent reply other threads:[~2017-05-15 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 22:10 [PATCH] mtd: nand: tango: Fix incorrect use of SEQIN command Boris Brezillon
2017-05-15 22:30 ` Boris Brezillon [this message]
2017-05-17 8:38 ` Marc Gonzalez
2017-05-29 18:53 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516003001.636a9cac@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox