From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Jan Glauber <jglauber@cavium.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH 2/2] nand: cavium: Nand flash controller for Cavium ARM64 SOCs
Date: Mon, 22 May 2017 13:44:37 +0200 [thread overview]
Message-ID: <20170522134437.5947abf7@bbrezillon> (raw)
In-Reply-To: <20170327160524.29019-3-jglauber@cavium.com>
On Mon, 27 Mar 2017 18:05:24 +0200
Jan Glauber <jglauber@cavium.com> wrote:
> Add a driver for the nand flash controller as found on Cavium's
> ARM64 SOCs.
>
> The nand flash controller can support up to 8 chips and is presented
> as a PCI device. It uses a DMA engine to transfer data between the nand
> and L2/DRAM and a programmable command queue to issue multiple
> nand flash commands together.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
> ---
> drivers/mtd/nand/Kconfig | 6 +
> drivers/mtd/nand/Makefile | 1 +
> drivers/mtd/nand/cavium_nand.c | 1160 ++++++++++++++++++++++++++++++++++++++++
> drivers/mtd/nand/cavium_nand.h | 231 ++++++++
Just noticed that you create a .h file to define driver structs and
macros, but those definitions are actually only used in cavium_nand.c.
Please move everything to cavium_nand.c.
next prev parent reply other threads:[~2017-05-22 11:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 16:05 [RFC PATCH 0/2] Cavium NAND flash driver Jan Glauber
2017-03-27 16:05 ` [RFC PATCH 1/2] dt-bindings: mtd: Add Cavium SOCs NAND bindings Jan Glauber
2017-03-28 20:20 ` Boris Brezillon
2017-03-28 21:30 ` Jan Glauber
2017-04-03 13:29 ` Rob Herring
2017-04-03 14:38 ` Jan Glauber
2017-04-03 14:47 ` Rob Herring
2017-04-03 16:18 ` Jan Glauber
2017-03-27 16:05 ` [RFC PATCH 2/2] nand: cavium: Nand flash controller for Cavium ARM64 SOCs Jan Glauber
2017-03-29 9:29 ` Boris Brezillon
2017-03-29 10:02 ` Jan Glauber
2017-03-29 13:59 ` Boris Brezillon
2017-04-25 11:26 ` Jan Glauber
2017-04-30 13:01 ` Boris Brezillon
2017-05-15 12:33 ` Boris Brezillon
2017-05-15 12:35 ` Boris Brezillon
2017-05-19 7:51 ` Boris Brezillon
2017-05-22 11:35 ` Jan Glauber
2017-05-22 11:53 ` Boris Brezillon
2017-05-22 11:44 ` Boris Brezillon [this message]
2017-07-20 20:25 ` [RFC PATCH 0/2] Cavium NAND flash driver Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522134437.5947abf7@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=jglauber@cavium.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox