linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Matthias Lange <matthias.lange@kernkonzept.com>
Cc: linux-mtd@lists.infradead.org, han.xu@nxp.com,
	computersforpeace@gmail.com, richard@nod.at, dwmw2@infradead.org
Subject: Re: [PATCH] Fix typo in comment.
Date: Fri, 2 Jun 2017 09:23:52 +0200	[thread overview]
Message-ID: <20170602092352.449c97be@bbrezillon> (raw)
In-Reply-To: <ed4d18bf-a18a-ea5c-5fc0-79a60fb3f2ee@kernkonzept.com>

On Wed, 31 May 2017 17:07:54 +0200
Matthias Lange <matthias.lange@kernkonzept.com> wrote:

> Hi Boris,
> 
> please consider the new version of the commit.

Can you send the patch you've put in attachment using git send-email
and Cc all relevant maintainers?

> 
> Best,
> Matthias.
> 
> 
> On 05/31/2017 11:22 AM, Boris Brezillon wrote:
> > Hi Mattias,
> > 
> > On Tue, 30 May 2017 09:41:31 +0200
> > Matthias Lange <matthias.lange@kernkonzept.com> wrote:
> > 
> > Commit title should be prefixed with "mtd: nand: gpmi: ".
> >   
> >> Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com>
> >> ---
> >>  drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> >> index 141bd70..41f53ae 100644
> >> --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> >> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> >> @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode)
> >>  
> >>  	nand->select_chip(mtd, 0);
> >>  
> >> -	/* [1] send SET FEATURE commond to NAND */
> >> +	/* [1] send SET FEATURE command to NAND */
> >>  	feature[0] = mode;
> >>  	ret = nand->onfi_set_features(mtd, nand,
> >>  				ONFI_FEATURE_ADDR_TIMING_MODE, feature);  

      reply	other threads:[~2017-06-02  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30  7:41 [PATCH] Fix typo in comment Matthias Lange
2017-05-31  9:22 ` Boris Brezillon
2017-05-31 15:07   ` Matthias Lange
2017-06-02  7:23     ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602092352.449c97be@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=han.xu@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthias.lange@kernkonzept.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).