Re: [PATCH v5 19/23] mtd: nand: denali: fix raw and oob accessors for syndrome page layout

Masahiro Yamada
2017-06-08T11:23:41Z

2017-06-07 23:09 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> On Wed, 7 Jun 2017 20:52:28 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
>>
>> +static void denali_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
>> +{
>> + struct denali_nand_info *denali = mtd_to_denali(mtd);
>> + int i;
>> +
>> + iowrite32(MODE_11 | BANK(denali->flash_bank) | 2, denali->flash_mem);
>
> What is this '| 2'? You seem to use it a lot. Can you define a macro
> and maybe add a comment if the macro name is not self-descriptive.

The type of access.

bit[1:0] == 0 : command cycle
1 : address cycle
2 : data read/write cycle

I will replace magic numbers
with macros or something.

--
Best Regards
Masahiro Yamada