Re: [PATCH v5 00/23] mtd: nand: denali: Denali NAND IP patch bomb

Boris Brezillon
2017-06-08T07:14:50Z

Le Thu, 8 Jun 2017 15:16:53 +0900,
Masahiro Yamada <yamada.masahiro@socionext.com> a écrit :

> Hi Boris,
>
> 2017-06-07 20:52 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > This patch series intends to solve various problems.
> >
> > [1] The driver just retrieves the OOB area as-is
> > whereas the controller uses syndrome page layout.
> > [2] Many NAND chip specific parameters are hard-coded in the driver.
> > [3] ONFi devices are not working
> > [4] It can not read Bad Block Marker
> >
> > Outstanding changes are:
> > - Fix raw/oob callbacks for syndrome page layout
> > - Implement setup_data_interface() callback
> > - Fix/implement more commands for ONFi devices
> > - Allow to skip the driver internal bounce buffer
> > - Support PIO in case DMA is not supported
> > - Switch from ->cmdfunc over to ->cmd_ctrl
>
>
> I am planning v6, but
> how many can you pick-up from this series?
>
> I did not see your comments for 01-05, so are they applicable?

They look good. Didn't apply them yet though.

>
> Could you add
> Acked-by: Rob Herring <robh@kernel.org>
> for 05 (http://patchwork.ozlabs.org/patch/772388/)
>
> He had already acked it, but I just missed it.

Yep, will do.