Re: [PATCH v5 00/23] mtd: nand: denali: Denali NAND IP patch bomb

Boris Brezillon
2017-06-08T07:19:11Z

Le Thu, 8 Jun 2017 16:12:49 +0900,
Masahiro Yamada <yamada.masahiro@socionext.com> a écrit :

> 2017-06-08 15:16 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > Hi Boris,
> >
> > 2017-06-07 20:52 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> >> This patch series intends to solve various problems.
> >>
> >> [1] The driver just retrieves the OOB area as-is
> >> whereas the controller uses syndrome page layout.
> >> [2] Many NAND chip specific parameters are hard-coded in the driver.
> >> [3] ONFi devices are not working
> >> [4] It can not read Bad Block Marker
> >>
> >> Outstanding changes are:
> >> - Fix raw/oob callbacks for syndrome page layout
> >> - Implement setup_data_interface() callback
> >> - Fix/implement more commands for ONFi devices
> >> - Allow to skip the driver internal bounce buffer
> >> - Support PIO in case DMA is not supported
> >> - Switch from ->cmdfunc over to ->cmd_ctrl
> >
> >
> > I am planning v6, but
> > how many can you pick-up from this series?
> >
> > I did not see your comments for 01-05, so are they applicable?
> >
> > Could you add
> > Acked-by: Rob Herring <robh@kernel.org>
> > for 05 (http://patchwork.ozlabs.org/patch/772388/)
> >
> > He had already acked it, but I just missed it.
> >
>
> BTW, this series can not apply to Boris's tree
> because of the following commit.
>
> commit 4a78cc644eed3cf2dae00c3a959910a86c140fd6
> Author: Boris Brezillon <boris.brezillon@free-electrons.com>
> Date: Fri May 26 17:10:15 2017 +0200
>
> mtd: nand: Make sure drivers not supporting SET/GET_FEATURES
> return -ENOTSUPP
>
>
>
> I will send v6 rebased on nand/next branch.
>

Please wait a bit before spamming the ML again. I'd like to finish
reviewing patches and apply uncontroversial ones.