* [PATCH] mtd: nand: fsl_ifc: remove unused variable
@ 2017-06-09 10:47 Arnd Bergmann
2017-06-09 10:56 ` Boris Brezillon
2017-06-09 21:50 ` Pavel Machek
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-06-09 10:47 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, Richard Weinberger, David Woodhouse, Brian Norris,
Marek Vasut, Cyrille Pitchen, Pavel Machek, linux-mtd,
linux-kernel
This one was accidentally introduced without any references,
and it causes a harmless warning:
drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/nand/fsl_ifc_nand.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index 14ef2f4524ac..d1c4538f870f 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -693,8 +693,6 @@ static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip,
fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
if (ctrl->nand_stat & IFC_NAND_EVTER_STAT_ECCER) {
- int res;
-
if (!oob_required)
fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable
2017-06-09 10:47 [PATCH] mtd: nand: fsl_ifc: remove unused variable Arnd Bergmann
@ 2017-06-09 10:56 ` Boris Brezillon
2017-06-09 11:35 ` Arnd Bergmann
2017-06-09 21:50 ` Pavel Machek
1 sibling, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2017-06-09 10:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Cyrille Pitchen, Pavel Machek, linux-mtd, linux-kernel
On Fri, 9 Jun 2017 12:47:43 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> This one was accidentally introduced without any references,
> and it causes a harmless warning:
>
> drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
> drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
>
> Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
If you don't mind, I'll squash the change in the initial commit.
Thanks,
Boris
> ---
> drivers/mtd/nand/fsl_ifc_nand.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index 14ef2f4524ac..d1c4538f870f 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -693,8 +693,6 @@ static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip,
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>
> if (ctrl->nand_stat & IFC_NAND_EVTER_STAT_ECCER) {
> - int res;
> -
> if (!oob_required)
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable
2017-06-09 10:56 ` Boris Brezillon
@ 2017-06-09 11:35 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-06-09 11:35 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Cyrille Pitchen, Pavel Machek, linux-mtd,
Linux Kernel Mailing List
On Fri, Jun 9, 2017 at 12:56 PM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Fri, 9 Jun 2017 12:47:43 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
>> This one was accidentally introduced without any references,
>> and it causes a harmless warning:
>>
>> drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
>> drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
>>
>> Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> If you don't mind, I'll squash the change in the initial commit.
Sure, that's always the best way to do it when the commits are not yet stable.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable
2017-06-09 10:47 [PATCH] mtd: nand: fsl_ifc: remove unused variable Arnd Bergmann
2017-06-09 10:56 ` Boris Brezillon
@ 2017-06-09 21:50 ` Pavel Machek
1 sibling, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2017-06-09 21:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Boris Brezillon, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen, linux-mtd,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]
On Fri 2017-06-09 12:47:43, Arnd Bergmann wrote:
> This one was accidentally introduced without any references,
> and it causes a harmless warning:
>
> drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
> drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
>
> Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Thanks!
Pavel
> ---
> drivers/mtd/nand/fsl_ifc_nand.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index 14ef2f4524ac..d1c4538f870f 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -693,8 +693,6 @@ static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip,
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>
> if (ctrl->nand_stat & IFC_NAND_EVTER_STAT_ECCER) {
> - int res;
> -
> if (!oob_required)
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-09 21:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 10:47 [PATCH] mtd: nand: fsl_ifc: remove unused variable Arnd Bergmann
2017-06-09 10:56 ` Boris Brezillon
2017-06-09 11:35 ` Arnd Bergmann
2017-06-09 21:50 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox