Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable

Boris Brezillon
2017-06-09T10:56:26Z

On Fri, 9 Jun 2017 12:47:43 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> This one was accidentally introduced without any references,
> and it causes a harmless warning:
>
> drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
> drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
>
> Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

If you don't mind, I'll squash the change in the initial commit.

Thanks,

Boris

> ---
> drivers/mtd/nand/fsl_ifc_nand.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index 14ef2f4524ac..d1c4538f870f 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -693,8 +693,6 @@ static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip,
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>
> if (ctrl->nand_stat & IFC_NAND_EVTER_STAT_ECCER) {
> - int res;
> -
> if (!oob_required)
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>