From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gateway31.websitewelcome.com ([192.185.143.43]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dTNF1-0004ZG-C7 for linux-mtd@lists.infradead.org; Fri, 07 Jul 2017 06:59:53 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 299A019BC0 for ; Fri, 7 Jul 2017 01:59:27 -0500 (CDT) Date: Fri, 7 Jul 2017 01:59:26 -0500 From: "Gustavo A. R. Silva" To: Stefan Agner , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] mtd: nand: vf610_nfc: add NULL check on of_match_device() return value Message-ID: <20170707065926.GA25776@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return -ENODEV Signed-off-by: Gustavo A. R. Silva --- drivers/mtd/nand/vf610_nfc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 744ab10..ca0ab96 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -674,6 +674,11 @@ static int vf610_nfc_probe(struct platform_device *pdev) } of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev); + if (!of_id) { + dev_err(&pdev->dev, "Failed to match device!\n"); + return -ENODEV; + } + nfc->variant = (enum vf610_nfc_variant)of_id->data; for_each_available_child_of_node(nfc->dev->of_node, child) { -- 2.5.0