public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: Fix a docs build warning
Date: Mon, 31 Jul 2017 18:27:20 +0200	[thread overview]
Message-ID: <20170731182720.209d7842@bbrezillon> (raw)
In-Reply-To: <20170730161803.1593200e@lwn.net>

On Sun, 30 Jul 2017 16:18:03 -0600
Jonathan Corbet <corbet@lwn.net> wrote:

> Commit 0b4773fd1649 (mtd: nand: Drop unused cached programming support)
> removed the "cached" parameter from nand_write_page(), but did not update
> the kerneldoc comments, creating this docs build warning:
> 
>   ./drivers/mtd/nand/nand_base.c:2751: warning: Excess function parameter 'cached' description in 'nand_write_page'
> 
> Remove the offending line so we can have a little peace and quiet.

Applied to nand/fixes.

Thanks,

Boris

> 
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> ---
>  drivers/mtd/nand/nand_base.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 5fa5ddc94834..ba57d8970f27 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2741,7 +2741,6 @@ static int nand_write_page_syndrome(struct mtd_info *mtd,
>   * @buf: the data to write
>   * @oob_required: must write chip->oob_poi to OOB
>   * @page: page number to write
> - * @cached: cached programming
>   * @raw: use _raw version of write_page
>   */
>  static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,

      reply	other threads:[~2017-07-31 16:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-30 22:18 [PATCH] mtd: nand: Fix a docs build warning Jonathan Corbet
2017-07-31 16:27 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170731182720.209d7842@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=corbet@lwn.net \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox