From: Miquel RAYNAL <miquel.raynal@free-electrons.com>
To: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd-utils: tests: avoid using only one block in nandpagetest
Date: Thu, 24 Aug 2017 11:01:04 +0200 [thread overview]
Message-ID: <20170824110104.5740cfb1@xps13> (raw)
In-Reply-To: <e5fc2f53-738f-037b-6bd6-c1aa18d363f7@sigma-star.at>
Hi David,
> > The case 'first == last' leads to erasing the block before reading
> > it. Hence the test will fail with no actual reason.
> >
> So if some existing automated test setup were to use this, it would
> (as of right now) *always* fail and terminate with EXIT_FAILURE.
>
> > The patch does not forbid the use of -c1 as it could do it in
> > process_options() with a errmsg_die(). Instead, it warns the user
> > and uses a second block in order to avoid risking to break existing
> > scripts.
> But wouldn't exactly that change the behavior of such a setup by
> suddenly having all tests succeed?
>
> If this combination of options always fails anyway, wouldn't it be
> more appropriate to terminate with an error message in
> process_options instead?
I though you would prefer to do not exit with an error but I it is ok
for me, I will resend the patch, with an error thrown in
process_options().
Regards,
Miquèl
prev parent reply other threads:[~2017-08-24 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 13:57 [PATCH] mtd-utils: tests: avoid using only one block in nandpagetest Miquel Raynal
2017-08-24 8:40 ` David Oberhollenzer
2017-08-24 9:01 ` Miquel RAYNAL [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824110104.5740cfb1@xps13 \
--to=miquel.raynal@free-electrons.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox