linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com,
	marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: remove unused blockmask variable
Date: Tue, 19 Sep 2017 22:12:46 +0200	[thread overview]
Message-ID: <20170919221246.4e46cb9e@bbrezillon> (raw)
In-Reply-To: <20170902084938.15942-1-clabbe.montjoie@gmail.com>

On Sat,  2 Sep 2017 10:49:38 +0200
Corentin Labbe <clabbe.montjoie@gmail.com> wrote:

> This patch fix the following build warning:
> drivers/mtd/nand/nand_base.c:2671:30: attention : variable ‘blockmask’ set but not used [-Wunused-but-set-variable]

Applied.

Thanks,

Boris

> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  drivers/mtd/nand/nand_base.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 9900476a0afe..b875fd365084 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2668,7 +2668,7 @@ static uint8_t *nand_fill_oob(struct mtd_info *mtd, uint8_t *oob, size_t len,
>  static int nand_do_write_ops(struct mtd_info *mtd, loff_t to,
>  			     struct mtd_oob_ops *ops)
>  {
> -	int chipnr, realpage, page, blockmask, column;
> +	int chipnr, realpage, page, column;
>  	struct nand_chip *chip = mtd_to_nand(mtd);
>  	uint32_t writelen = ops->len;
>  
> @@ -2704,7 +2704,6 @@ static int nand_do_write_ops(struct mtd_info *mtd, loff_t to,
>  
>  	realpage = (int)(to >> chip->page_shift);
>  	page = realpage & chip->pagemask;
> -	blockmask = (1 << (chip->phys_erase_shift - chip->page_shift)) - 1;
>  
>  	/* Invalidate the page cache, when we write to the cached page */
>  	if (to <= ((loff_t)chip->pagebuf << chip->page_shift) &&

      reply	other threads:[~2017-09-19 20:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02  8:49 [PATCH] mtd: nand: remove unused blockmask variable Corentin Labbe
2017-09-19 20:12 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919221246.4e46cb9e@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=clabbe.montjoie@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).