From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali
Date: Fri, 29 Sep 2017 14:26:35 +0200 [thread overview]
Message-ID: <20170929142635.07d55f77@bbrezillon> (raw)
In-Reply-To: <1506681520-13897-1-git-send-email-yamada.masahiro@socionext.com>
On Fri, 29 Sep 2017 19:38:38 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> 1/2 : add NAND_WAIT_TWHR and nand_whr_delay().
> You can set this new flag if you want nand_command(_lp)
> to insert tWHR delay where needed.
>
> 2/2 : Fix Denali setup_data_interface.
> Boris' suggestion in v1 was a good reminder that
> made me realize tCCS was missing in the driver. Fix it now.
>
>
> Changes in v2:
> - Add nand_whr_delay() helper
> Wait for tWHR only for drivers that explicitly set NAND_WAIT_TWHR flag
> - newly added
>
> Masahiro Yamada (2):
> mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID
Hm, I thought you were introducing this to then use it in the denali
driver. Sorry, but I don't want to apply something that nobody needs.
If someone ever complains about a missing delay I'll point him to your
patch, but until then I'll keep the core unchanged.
> mtd: nand: denali: fix setup_data_interface to meet tCCS delay
This one is valid. I'll queue it to nand/next soon.
Thanks,
Boris
>
> drivers/mtd/nand/denali.c | 10 ++++++++--
> drivers/mtd/nand/nand_base.c | 21 +++++++++++++++++++--
> include/linux/mtd/rawnand.h | 13 ++++++++-----
> 3 files changed, 35 insertions(+), 9 deletions(-)
>
next prev parent reply other threads:[~2017-09-29 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 10:38 [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali Masahiro Yamada
2017-09-29 10:38 ` [PATCH v2 1/2] mtd: nand: wait for tWHR after NAND_CMD_STATUS / NAND_CMD_READID Masahiro Yamada
2017-09-29 10:38 ` [PATCH v2 2/2] mtd: nand: denali: fix setup_data_interface to meet tCCS delay Masahiro Yamada
2017-09-29 12:26 ` Boris Brezillon [this message]
2017-09-29 14:06 ` [PATCH v2 0/2] mtd: nand: wait for tWHR, and fix the setup_data_interface of Denali Masahiro Yamada
2017-09-29 14:29 ` Boris Brezillon
2017-09-29 14:33 ` Masahiro Yamada
2017-10-04 11:05 ` Marc Gonzalez
2017-10-13 8:34 ` Masahiro Yamada
2017-10-19 14:58 ` Marc Gonzalez
2017-10-25 17:04 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929142635.07d55f77@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox