* [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table
@ 2017-10-06 21:51 Linus Walleij
2017-10-07 5:49 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2017-10-06 21:51 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-mtd
Cc: linux-arm-kernel, Robert Jarzmik, Linus Walleij, arm
My patch set the device name wrong because I confused the
device name for a partition name. Sorry.
Cc: arm@kernel.org
Fixes: ("mtd: nand: gpio: Convert to use GPIO descriptors")
Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
This can be squashed into the commit or applied on top
as a fix. The original patch was ACKed by the ARM SoC
maintainers so I believe this is fine to apply.
---
arch/arm/mach-pxa/cm-x255.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-pxa/cm-x255.c b/arch/arm/mach-pxa/cm-x255.c
index f8d67acb7194..fa8e7dd4d898 100644
--- a/arch/arm/mach-pxa/cm-x255.c
+++ b/arch/arm/mach-pxa/cm-x255.c
@@ -178,7 +178,7 @@ static inline void cmx255_init_nor(void) {}
#if defined(CONFIG_MTD_NAND_GPIO) || defined(CONFIG_MTD_NAND_GPIO_MODULE)
static struct gpiod_lookup_table cmx255_nand_gpiod_table = {
- .dev_id = "cmx255-nand",
+ .dev_id = "gpio-nand",
.table = {
GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CS, "nce", GPIO_ACTIVE_HIGH),
GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CLE, "cle", GPIO_ACTIVE_HIGH),
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table
2017-10-06 21:51 [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table Linus Walleij
@ 2017-10-07 5:49 ` Boris Brezillon
2017-10-07 8:00 ` Robert Jarzmik
0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2017-10-07 5:49 UTC (permalink / raw)
To: Linus Walleij
Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
Cyrille Pitchen, linux-mtd, linux-arm-kernel, Robert Jarzmik, arm
On Fri, 6 Oct 2017 23:51:44 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> My patch set the device name wrong because I confused the
> device name for a partition name. Sorry.
>
> Cc: arm@kernel.org
> Fixes: ("mtd: nand: gpio: Convert to use GPIO descriptors")
> Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This can be squashed into the commit or applied on top
> as a fix. The original patch was ACKed by the ARM SoC
> maintainers so I believe this is fine to apply.
> ---
> arch/arm/mach-pxa/cm-x255.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/cm-x255.c b/arch/arm/mach-pxa/cm-x255.c
> index f8d67acb7194..fa8e7dd4d898 100644
> --- a/arch/arm/mach-pxa/cm-x255.c
> +++ b/arch/arm/mach-pxa/cm-x255.c
> @@ -178,7 +178,7 @@ static inline void cmx255_init_nor(void) {}
> #if defined(CONFIG_MTD_NAND_GPIO) || defined(CONFIG_MTD_NAND_GPIO_MODULE)
>
> static struct gpiod_lookup_table cmx255_nand_gpiod_table = {
> - .dev_id = "cmx255-nand",
> + .dev_id = "gpio-nand",
Are you sure it works? AFAIR, you have to set "<driver-name>.<dev-id>"
here, which, assuming there's only one gpio-nand dev, would give
.dev_id = "gpio-nand.0",
Regards,
Boris
> .table = {
> GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CS, "nce", GPIO_ACTIVE_HIGH),
> GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CLE, "cle", GPIO_ACTIVE_HIGH),
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table
2017-10-07 5:49 ` Boris Brezillon
@ 2017-10-07 8:00 ` Robert Jarzmik
2017-10-07 9:22 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Robert Jarzmik @ 2017-10-07 8:00 UTC (permalink / raw)
To: Boris Brezillon, Linus Walleij
Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
Cyrille Pitchen, linux-mtd, linux-arm-kernel, arm
Boris Brezillon <boris.brezillon@free-electrons.com> writes:
> On Fri, 6 Oct 2017 23:51:44 +0200
> Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> My patch set the device name wrong because I confused the
>> device name for a partition name. Sorry.
>>
>> Cc: arm@kernel.org
>> Fixes: ("mtd: nand: gpio: Convert to use GPIO descriptors")
>> Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> This can be squashed into the commit or applied on top
>> as a fix. The original patch was ACKed by the ARM SoC
>> maintainers so I believe this is fine to apply.
>> ---
>> arch/arm/mach-pxa/cm-x255.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-pxa/cm-x255.c b/arch/arm/mach-pxa/cm-x255.c
>> index f8d67acb7194..fa8e7dd4d898 100644
>> --- a/arch/arm/mach-pxa/cm-x255.c
>> +++ b/arch/arm/mach-pxa/cm-x255.c
>> @@ -178,7 +178,7 @@ static inline void cmx255_init_nor(void) {}
>> #if defined(CONFIG_MTD_NAND_GPIO) || defined(CONFIG_MTD_NAND_GPIO_MODULE)
>>
>> static struct gpiod_lookup_table cmx255_nand_gpiod_table = {
>> - .dev_id = "cmx255-nand",
>> + .dev_id = "gpio-nand",
>
> Are you sure it works? AFAIR, you have to set "<driver-name>.<dev-id>"
> here, which, assuming there's only one gpio-nand dev, would give
>
> .dev_id = "gpio-nand.0",
I'm sure Linus is correct this time.
This is because :
static struct platform_device cmx255_nand = {
...
.id = -1,
...
This -1 is the reason it will be "gpio-nand".
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
--
Robert
PS: For the next time for pxa patches I'd appreciate to be in the "To:" list, as
my other pxa co-maintainers.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table
2017-10-07 8:00 ` Robert Jarzmik
@ 2017-10-07 9:22 ` Boris Brezillon
0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2017-10-07 9:22 UTC (permalink / raw)
To: Robert Jarzmik
Cc: Linus Walleij, David Woodhouse, Brian Norris, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-mtd, linux-arm-kernel,
arm
On Sat, 07 Oct 2017 10:00:16 +0200
Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Boris Brezillon <boris.brezillon@free-electrons.com> writes:
>
> > On Fri, 6 Oct 2017 23:51:44 +0200
> > Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> >> My patch set the device name wrong because I confused the
> >> device name for a partition name. Sorry.
> >>
> >> Cc: arm@kernel.org
> >> Fixes: ("mtd: nand: gpio: Convert to use GPIO descriptors")
> >> Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >> This can be squashed into the commit or applied on top
> >> as a fix. The original patch was ACKed by the ARM SoC
> >> maintainers so I believe this is fine to apply.
> >> ---
> >> arch/arm/mach-pxa/cm-x255.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/mach-pxa/cm-x255.c b/arch/arm/mach-pxa/cm-x255.c
> >> index f8d67acb7194..fa8e7dd4d898 100644
> >> --- a/arch/arm/mach-pxa/cm-x255.c
> >> +++ b/arch/arm/mach-pxa/cm-x255.c
> >> @@ -178,7 +178,7 @@ static inline void cmx255_init_nor(void) {}
> >> #if defined(CONFIG_MTD_NAND_GPIO) || defined(CONFIG_MTD_NAND_GPIO_MODULE)
> >>
> >> static struct gpiod_lookup_table cmx255_nand_gpiod_table = {
> >> - .dev_id = "cmx255-nand",
> >> + .dev_id = "gpio-nand",
> >
> > Are you sure it works? AFAIR, you have to set "<driver-name>.<dev-id>"
> > here, which, assuming there's only one gpio-nand dev, would give
> >
> > .dev_id = "gpio-nand.0",
> I'm sure Linus is correct this time.
> This is because :
> static struct platform_device cmx255_nand = {
> ...
> .id = -1,
> ...
>
> This -1 is the reason it will be "gpio-nand".
Right. I thought -1 was PLATFORM_DEVID_AUTO, but it's
PLATFORM_DEVID_NONE.
I'll squash the change in the initial commit.
Thanks,
Boris
>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-07 9:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-06 21:51 [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table Linus Walleij
2017-10-07 5:49 ` Boris Brezillon
2017-10-07 8:00 ` Robert Jarzmik
2017-10-07 9:22 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).