From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h
Date: Thu, 12 Oct 2017 11:31:01 +0100 [thread overview]
Message-ID: <20171012112959.4d2310a8@alans-desktop> (raw)
In-Reply-To: <1507292755.29211.353.camel@infradead.org>
On Fri, 06 Oct 2017 13:25:55 +0100
David Woodhouse <dwmw2@infradead.org> wrote:
> On Fri, 2017-10-06 at 14:13 +0200, Pavel Machek wrote:
> > > You can change 'C++' to 'C99' too, while you're at it :)
> >
> > No. They are C++ comments... as in... dangerous infection that came
> > from C++. Yes, C99 is infected, too, but still C++ is original source
> > of infection :-).
>
> C++ is a different language, and irrelevant here. You could call them
> Java comments if you want, but that would be equally silly. In the
> kernel, they are C99 comments. Valid, but not our preferred style
> (which is fair enough, unlike our idiotic refusal to use C99 integer
> types).
We might as well allow them. We are using those compiler settings so the
cases where your compilation produces different results in C99 and more
classic C are no longer a risk 8)
int main(int argc, char *argv[])
{
int x = 1//**/
-1;
if (x == 0)
puts("Ewww C99");
exit(0);
}
next prev parent reply other threads:[~2017-10-12 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 20:13 [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Pavel Machek
2017-09-23 21:10 ` Marek Vasut
2017-09-24 8:20 ` Boris Brezillon
2017-09-24 8:23 ` Richard Weinberger
2017-10-06 11:55 ` Pavel Machek
2017-10-06 12:00 ` Richard Weinberger
2017-10-06 12:01 ` David Woodhouse
2017-10-06 12:13 ` Pavel Machek
2017-10-06 12:25 ` David Woodhouse
2017-10-12 10:31 ` Alan Cox [this message]
2017-10-06 12:32 ` Al Viro
2017-10-06 13:04 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012112959.4d2310a8@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).