Re: [PATCH v3 1/7] memory: omap-gpmc: Refactor OneNAND support

[Ladislav Michl <ladis@linux-mips.org>]

On Thu, Nov 09, 2017 at 09:56:26AM -0800, Tony Lindgren wrote:
> Hi,
> 
> * Ladislav Michl <ladis@linux-mips.org> [171109 09:14]:
> > Use generic probe function to deal with OneNAND node and remove now useless
> > gpmc_probe_onenand_child function.
> > Import sync mode timing calculation function from mach-omap2/gpmc-onenand.c
> > and prepare for MTD driver DTfication.
> 
> I tried giving this series a try on n900, but looks like onenand is no longer
> seen on n900 after this first patch.

This first patch makes original driver stop working as it removes special
OneNAND handling. If it doesn't work even after applying whole serie, then:
- verify onenand node has compatible 'ti,omap2-onenand' property
- verify timings

On IGEPv2 bootlog shows:
[    1.544464] omap-gpmc 6e000000.gpmc: GPMC revision 5.0
[    1.550415] gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000
[    1.560485] omap2-onenand 30000000.onenand: initializing on CS0, phys base 0x30000000, virtual base e0080000
[    1.571014] Muxed OneNAND(DDP) 512MB 1.8V 16-bit (0x58)
[    1.576507] OneNAND version = 0x0031
[    1.583435] Scanning device for bad blocks
[    1.620971] OneNAND eraseblock 597 is an initial bad block
[    1.657470] OneNAND eraseblock 1159 is an initial bad block
[    1.754577] OneNAND eraseblock 2812 is an initial bad block
[    1.832214] omap2-onenand 30000000.onenand: optimized timings for 83 MHz
[    1.842620] 2 ofpart partitions found on MTD device 30000000.onenand
[    1.849426] Creating 2 MTD partitions on "30000000.onenand":
[    1.855651] 0x000000000000-0x000000080000 : "SPL"
[    1.863464] 0x000000080000-0x000020000000 : "UBI"

For a start:

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 4acd32a1c4ef..aa5b1a439564 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -838,6 +838,7 @@
 	onenand@0,0 {
 		#address-cells = <1>;
 		#size-cells = <1>;
+		compatible = "ti,omap2-onenand";
 		reg = <0 0 0x20000>;	/* CS0, offset 0, IO size 128K */
 
 		gpmc,sync-read;