From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eD5vL-0007zj-Vz for linux-mtd@lists.infradead.org; Fri, 10 Nov 2017 09:48:34 +0000 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23990595AbdKJJsHVrI0W (ORCPT ); Fri, 10 Nov 2017 10:48:07 +0100 Date: Fri, 10 Nov 2017 10:48:06 +0100 Sender: Ladislav Michl From: Ladislav Michl To: Roger Quadros Cc: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, Tony Lindgren , Boris Brezillon , Kyungmin Park Subject: Re: [PATCH v3 4/7] mtd: onenand: omap2: Remove partitioning support from platform data Message-ID: <20171110094806.22i4q7jekigeozmo@lenoch> References: <20171109091155.6a6azfvjarwvlfh2@lenoch> <20171109091444.dxvoaaafjgkf43a2@lenoch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Nov 10, 2017 at 10:19:11AM +0200, Roger Quadros wrote: > On 09/11/17 11:14, Ladislav Michl wrote: > > No platform data user setups partitioning informations, so remove. > > > > Signed-off-by: Ladislav Michl > > --- > > Changes: > > -v2: new patch > > -v3: none > > > > drivers/mtd/onenand/omap2.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c > > index 93bd94337b35..883993bbe40b 100644 > > --- a/drivers/mtd/onenand/omap2.c > > +++ b/drivers/mtd/onenand/omap2.c > > @@ -703,8 +703,7 @@ static int omap2_onenand_probe(struct platform_device *pdev) > > if ((r = onenand_scan(&c->mtd, 1)) < 0) > > goto err_release_dma; > > > > - r = mtd_device_register(&c->mtd, pdata ? pdata->parts : NULL, > > - pdata ? pdata->nr_parts : 0); > > + r = mtd_device_register(&c->mtd, NULL, 0); > > if (r) > > goto err_release_onenand; > > > > > > Same here. Need to update platform data structure. I do not want to unnecessarily extend patch as I hope no sane maintainer would ever allow anyone to add any new platform data dependency while we are moving towards DT only configured kernel. Platform data structure will be deleted entirely together with arch/arm/mach-omap2/gpmc-onenand.c once driver update gets accepted. ladis