Re: [PATCH v4 13/16] memory: omap-gpmc: Refactor OneNAND support

Ladislav Michl
2017-11-15T10:37:33Z

On Wed, Nov 15, 2017 at 12:13:56PM +0200, Roger Quadros wrote:
> On 11/11/17 23:26, Ladislav Michl wrote:
[snip]
> > +/**
> > + * gpmc_omap_onenand_set_timings - set optimized sync timings.
> > + * @cs: Chip Select Region
> > + * @freq: Chip frequency
> > + * @latency: Burst latency cycle count
> > + * @info: Structure describing parameters used
>
> How about adding some description? e.g.
>
> sets optimized timings for the provided @cs region based on
> provided @freq and @latency. Updates the @info structure based on
> the GPMC settings.

Added to v5, thank you.

Side question: u-boot has patman to deal with patch changelog. Is there
something similar or even better for linux? For the time being I setup
patman...