Re: [PATCH v4 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO

Sebastian Reichel
2017-11-15T15:00:36Z

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

Hi,

On Sat, Nov 11, 2017 at 10:20:58PM +0100, Ladislav Michl wrote:
> Use wait_for_completion_io_timeout, which has an impact on how the
> task is accounted in scheduling stats.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> Changes:
> -v4: new patch
>
> drivers/mtd/onenand/omap2.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 883993bbe40b..0e7772e16d75 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -170,9 +170,8 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state)
> if (result == 0) {
> int retry_cnt = 0;
> retry:
> - result = wait_for_completion_timeout(&c->irq_done,
> - msecs_to_jiffies(20));
> - if (result == 0) {
> + if (!wait_for_completion_io_timeout(&c->irq_done,
> + msecs_to_jiffies(20))) {
> /* Timeout after 20ms */
> ctrl = read_reg(c, ONENAND_REG_CTRL_STATUS);
> if (ctrl & ONENAND_CTRL_ONGO &&
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]