From: Miquel RAYNAL <miquel.raynal@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Mark Rutland <mark.rutland@arm.com>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Richard Weinberger <richard@nod.at>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Stefan Agner <stefan@agner.ch>,
Wenyou Yang <wenyou.yang@atmel.com>,
Nadav Haklai <nadavh@marvell.com>,
Marek Vasut <marek.vasut@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Han Xu <han.xu@nxp.com>,
Brian Norris <computersforpeace@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Josh Wu <rainyfeeling@outlook.com>
Subject: Re: [RFC PATCH v2 1/6] mtd: nand: provide several helpers to do common NAND operations
Date: Thu, 30 Nov 2017 14:48:39 +0100 [thread overview]
Message-ID: <20171130144839.08b8b7ce@xps13> (raw)
In-Reply-To: <CAK7LNARFHqg+EE6m0pxx7Pbs+p-w+W0MMtu4kgXLNBhfeycXVA@mail.gmail.com>
Hi Sean, Boris,
> >> Theoretically, there could be three cases:
> >> [1] INTR__ERASE_COMP interrupt is asserted
> >> [2] INTR__ERASE_FAIL interrupt is asserted
> >> [3] Nothing is asserted (bailout by timeout)
> >
> > Well, ideally we should have something like:
> >
> > if (irq_status & INTR__ERASE_COMP)
> > return 0;
> > else if (irq_status & INTR__ERASE_FAIL)
> > return -EIO;
> >
> > return -ETIMEDOUT;
> >
> > But let's keep the existing behavior (return -EIO in case of
> > timeout).
>
>
> I agree with this change,
> but it should also be done in a separate work.
>
>
Ok, I will stick to Boris' first solution and put this aside.
Patches will come very soon.
Thank you both,
Miquèl
next prev parent reply other threads:[~2017-11-30 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 14:54 [RFC PATCH v2 0/6] Marvell NAND controller rework with ->exec_op() Miquel Raynal
2017-11-07 14:54 ` [RFC PATCH v2 1/6] mtd: nand: provide several helpers to do common NAND operations Miquel Raynal
2017-11-08 10:48 ` Boris Brezillon
2017-11-08 16:37 ` Boris Brezillon
2017-11-30 7:44 ` Masahiro Yamada
2017-11-30 8:18 ` Boris Brezillon
2017-11-30 10:38 ` Masahiro Yamada
2017-11-30 13:48 ` Miquel RAYNAL [this message]
2017-11-07 14:54 ` [RFC PATCH v2 2/6] mtd: nand: force drivers to explicitly send READ/PROG commands Miquel Raynal
2017-11-08 14:23 ` Boris Brezillon
2017-11-07 14:54 ` [RFC PATCH v2 3/6] mtd: nand: use a static data_interface in the nand_chip structure Miquel Raynal
2017-11-08 14:54 ` Boris Brezillon
2017-11-07 14:54 ` [RFC PATCH v2 4/6] mtd: nand: add ->exec_op() implementation Miquel Raynal
2017-11-08 16:31 ` Boris Brezillon
2017-11-07 14:54 ` [RFC PATCH v2 5/6] dt-bindings: mtd: add Marvell NAND controller documentation Miquel Raynal
2017-11-07 14:54 ` [RFC PATCH v2 6/6] mtd: nand: add reworked Marvell NAND controller driver Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130144839.08b8b7ce@xps13 \
--to=miquel.raynal@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=han.xu@nxp.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=rainyfeeling@outlook.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wenyou.yang@atmel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).