public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Cc: <linux-mtd@lists.infradead.org>,
	oss@buserror.net, computersforpeace@gmail.com,
	Jagdish Gediya <jagdish.gediya@nxp.com>,
	dedekind1@gmail.com
Subject: Re: [PATCH][v2] mtd: nand: ifc: update bufnum mask for ver >= 2.0.0
Date: Thu, 30 Nov 2017 22:37:51 +0100	[thread overview]
Message-ID: <20171130223751.78f586bd@bbrezillon> (raw)
In-Reply-To: <1511436871-15346-1-git-send-email-prabhakar.kushwaha@nxp.com>

On Thu, 23 Nov 2017 17:04:31 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:

> From: Jagdish Gediya <jagdish.gediya@nxp.com>
> 
> Bufnum mask is used to calculate page position in the internal SRAM.
> 
> As IFC version 2.0.0 has 16KB of internal SRAM as compared to older
> versions which had 8KB. Hence bufnum mask needs to be updated.

Applied.

Thanks,

Boris

> 
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> Changes for v2: Incorporated review comments from Boris Brezillon
> http://patchwork.ozlabs.org/patch/773799/
> 
>  drivers/mtd/nand/fsl_ifc_nand.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index 9e03bac..bbdd68a5 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -916,6 +916,13 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
>  	if (ctrl->version >= FSL_IFC_VERSION_1_1_0)
>  		fsl_ifc_sram_init(priv);
>  
> +	/*
> +	 * As IFC version 2.0.0 has 16KB of internal SRAM as compared to older
> +	 * versions which had 8KB. Hence bufnum mask needs to be updated.
> +	 */
> +	if (ctrl->version >= FSL_IFC_VERSION_2_0_0)
> +		priv->bufnum_mask = (priv->bufnum_mask * 2) + 1;
> +
>  	return 0;
>  }
>  

      reply	other threads:[~2017-11-30 21:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 11:34 [PATCH][v2] mtd: nand: ifc: update bufnum mask for ver >= 2.0.0 Prabhakar Kushwaha
2017-11-30 21:37 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130223751.78f586bd@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=jagdish.gediya@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=oss@buserror.net \
    --cc=prabhakar.kushwaha@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox