public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Richard Weinberger <richard@nod.at>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
	linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: gpio: Fix ALE gpio configuration
Date: Wed, 6 Dec 2017 23:39:27 +0100	[thread overview]
Message-ID: <20171206233927.3869372b@bbrezillon> (raw)
In-Reply-To: <18914914.8jQtQ4ab2h@blindfold>

On Wed, 06 Dec 2017 23:28:11 +0100
Richard Weinberger <richard@nod.at> wrote:

> Am Mittwoch, 6. Dezember 2017, 18:27:14 CET schrieb Christophe Leroy:
> > Fixes a copy/paste error in commit f3d0d8d938b4d ("mtd: nand: gpio:
> > Convert to use GPIO descriptors") which breaks gpio-nand driver
> > 
> > Fixes: f3d0d8d938b4d ("mtd: nand: gpio: Convert to use GPIO descriptors")
> > Cc: Linus Walleij <linus.walleij@linaro.org>

Cc: <stable@vger.kernel.org>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Richard, can you queue that one to the fixes branch?

> > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > ---
> >  drivers/mtd/nand/gpio.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
> > index 484f7fbc3f7d..a8bde6665c24 100644
> > --- a/drivers/mtd/nand/gpio.c
> > +++ b/drivers/mtd/nand/gpio.c
> > @@ -253,9 +253,9 @@ static int gpio_nand_probe(struct platform_device *pdev)
> > goto out_ce;
> >  	}
> > 
> > -	gpiomtd->nwp = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > -	if (IS_ERR(gpiomtd->nwp)) {
> > -		ret = PTR_ERR(gpiomtd->nwp);
> > +	gpiomtd->ale = devm_gpiod_get(dev, "ale", GPIOD_OUT_LOW);
> > +	if (IS_ERR(gpiomtd->ale)) {
> > +		ret = PTR_ERR(gpiomtd->ale);
> >  		goto out_ce;
> >  	}  
> 
> Reviewed-by: Richard Weinberger <richard@nod.at>
> 
> Thanks,
> //richard

  reply	other threads:[~2017-12-06 22:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 17:27 [PATCH] mtd: nand: gpio: Fix ALE gpio configuration Christophe Leroy
2017-12-06 22:28 ` Richard Weinberger
2017-12-06 22:39   ` Boris Brezillon [this message]
2017-12-06 22:45     ` Boris Brezillon
2017-12-10  0:26 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206233927.3869372b@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox