From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eN2da-0003Wm-8D for linux-mtd@lists.infradead.org; Thu, 07 Dec 2017 20:19:26 +0000 Date: Thu, 7 Dec 2017 21:18:43 +0100 From: Boris Brezillon To: Masahiro Yamada Cc: Richard Weinberger , linux-mtd , Marek Vasut , Brian Norris , David Woodhouse , Cyrille Pitchen Subject: Re: [PATCH 1/2] mtd: nand: denali: Avoid using ecc->code_buf as a temporary buffer Message-ID: <20171207211843.4fd4bbbd@bbrezillon> In-Reply-To: References: <20171205110929.6820-1-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 5 Dec 2017 21:37:45 +0900 Masahiro Yamada wrote: > 2017-12-05 20:09 GMT+09:00 Boris Brezillon : > > ECC bytes are contiguous in the ->oob_poi buffer, which means we don't > > have to copy them into the ->code_buf (here used as a temporary buffer) > > before passing them to the nand_check_erased_ecc_chunk() function. > > > > This change will allow us to allocate ecc->{code,calc}_buf only when > > ecc->calculate() or ecc->correct() is specified. > > > > Signed-off-by: Boris Brezillon > > Acked-by: Masahiro Yamada Applied those 2 patches. Boris > > Thanks! > > > >