From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.free-electrons.com ([62.4.15.54])
 by merlin.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux))
 id 1eYXaO-0001yy-JK
 for linux-mtd@lists.infradead.org; Mon, 08 Jan 2018 13:35:33 +0000
Date: Mon, 8 Jan 2018 14:35:05 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "kernelci.org bot" <bot@kernelci.org>, Kernel Build Reports Mailman List
 <kernel-build-reports@lists.linaro.org>, Sean =?UTF-8?B?Tnlla2rDpnI=?=
 <sean.nyekjaer@prevas.dk>, Willy Tarreau <w@1wt.eu>, Ezequiel Garcia
 <ezequiel@vanguardiasur.com.ar>, Robert Jarzmik <robert.jarzmik@free.fr>,
 Richard Weinberger <richard@nod.at>, linux-mtd
 <linux-mtd@lists.infradead.org>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, "# 4.4.x" <stable@vger.kernel.org>, gregkh
 <gregkh@linuxfoundation.org>
Subject: Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed,
 8 errors (v4.4.110-18-g5da3d9af3a4b)
Message-ID: <20180108143505.209fa2b2@bbrezillon>
In-Reply-To: <CAK8P3a1U9Q2RzXiE2qdD-zU0u+=fm66V6Aw8RR8YSXd5Gbiq3A@mail.gmail.com>
References: <5a535545.93b5df0a.a7ca3.53c1@mx.google.com>
 <CAK8P3a1U9Q2RzXiE2qdD-zU0u+=fm66V6Aw8RR8YSXd5Gbiq3A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Hi Arnd,

On Mon, 8 Jan 2018 14:16:25 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@kernelci.org> wrot=
e:
> >
> > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors=
 (v4.4.110-18-g5da3d9af3a4b)
> > Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4=
.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/
> > Tree: stable-rc
> > Branch: linux-4.4.y
> > Git Describe: v4.4.110-18-g5da3d9af3a4b
> > Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9
> > Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-st=
able-rc.git
> > Built: 4 unique architectures
> >
> > Build Failures Detected:
> >
> > arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
> > cm_x300_defconfig FAIL
> > mvebu_v7_defconfig FAIL
> > pxa3xx_defconfig FAIL
> > raumfeld_defconfig FAIL
> >
> > mvebu_v7_defconfig (arm) =E2=80=94 FAIL, 2 errors, 0 warnings, 0 sectio=
n mismatches
> >
> > Errors:
> > drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value
> > drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here =20
>=20
> Hi Greg,
>=20
> Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was
> apparently backported in error, it looks like it should just be
> dropped here in 4.4.y.
>=20
> The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-spe=
cific
> ECC BCH support")', that commit was merged into v4.14,

git tag --contains says commit 43bcfd2bb24a has been merged in 3.14.

> so backporting the
> fix further is probably not appropriate for 4.9 or earlier kernels either.
>=20
> The duplicate case statement only happens before linux-4.6, as commit
> c2cdace755b5 ("mtd: nand: pxa3xx_nand: add support for partial chunks")'
> removed a previous 'case READOOB' statement in this driver, so the build
> regression appears only in 4.4 but not 4.9.

Crap, I didn't notice the NAND_READOOB case was handled before 4.6.
Still, the fix is needed, which means we'll have to revert this version
and create a custom one for 4.4.

Thanks for this report.

Boris