From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ecRIn-0004xJ-Sf for linux-mtd@lists.infradead.org; Fri, 19 Jan 2018 07:41:31 +0000 Date: Fri, 19 Jan 2018 08:41:18 +0100 From: Miquel Raynal To: Colin King Cc: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH][next] mtd: nand: remove redundant variable 'oob_len' Message-ID: <20180119084118.3450d47f@xps13> In-Reply-To: <20180116125748.26042-1-colin.king@canonical.com> References: <20180116125748.26042-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello, On Tue, 16 Jan 2018 12:57:48 +0000 Colin King wrote: > From: Colin Ian King >=20 > Variable oob_len is assigned and never read, hence it is redundant and > can be removed. >=20 > Cleans up clang warnings: >=20 > drivers/mtd/nand/marvell_nand.c:1356:6: warning: Value stored to > 'oob_len' during its initialization is never read > drivers/mtd/nand/marvell_nand.c:1369:4: warning: Value stored to > 'oob_len' is never read >=20 > Signed-off-by: Colin Ian King > --- Same as before, can you change the prefix to: mtd: nand: marvell: Thank you, Miqu=C3=A8l