From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.free-electrons.com ([62.4.15.54])
 by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux))
 id 1ectWL-0006fi-Ju
 for linux-mtd@lists.infradead.org; Sat, 20 Jan 2018 13:49:24 +0000
Date: Sat, 20 Jan 2018 14:49:06 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>, David Woodhouse
 <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek
 Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille
 Pitchen <cyrille.pitchen@wedev4u.fr>, <linux-mtd@lists.infradead.org>,
 <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err
 call in omap2_onenand_probe()
Message-ID: <20180120144906.3d22a204@bbrezillon>
In-Reply-To: <1516188333-144550-1-git-send-email-weiyongjun1@huawei.com>
References: <1516188333-144550-1-git-send-email-weiyongjun1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Wed, 17 Jan 2018 11:25:33 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:

> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied.

Thanks,

Boris

> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/mtd/onenand/omap2.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index a4a2159..87c34f6 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -532,10 +532,8 @@ static int omap2_onenand_probe(struct platform_device *pdev)
>  	c->phys_base = res->start;
>  
>  	c->onenand.base = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(c->onenand.base)) {
> -		dev_err(dev, "Cannot reserve memory region %pR\n", res);
> +	if (IS_ERR(c->onenand.base))
>  		return PTR_ERR(c->onenand.base);
> -	}
>  
>  	c->int_gpiod = devm_gpiod_get_optional(dev, "int", GPIOD_IN);
>  	if (IS_ERR(c->int_gpiod)) {
> 
> 
>