Re: [PATCH v2] mxc_nand controller fixes

[Boris Brezillon <boris.brezillon@bootlin.com>]

On Wed, 17 Jan 2018 12:32:05 +0100
Sascha Hauer <s.hauer@pengutronix.de> wrote:

> This series fixes several problems in the mxc_nand driver.
> 
> - Raw support does not work since hardware ECC is unconditionally
>   enabled
> - The v2/v3 controller code returns the number of corrected
>   bitflips for the whole page for each subpage leading to
>   results for times too high
> - The v1 controller code returns the number of corrected bitflips
>   only for the last subpage. On 2k page NANDs bitflips in the
>   first three subpages remain uncovered
> 
> This series fixes these issues. Tested with the mtd test modules
> mtd_nandbiterrs, mtd_oobtest, mtd_pagetest and mtd_readtest and the
> corresponding userspace tests from mtd-utils on a i.MX27 board which
> is a v1 controller and a i.MX25 board which is a v2 controller.
> 
> Based on nand/next.

Applied the whole series.

Thanks,

Boris

> 
> Sascha
> 
> Changes since v1:
> - drop mtd argument from read_page/write_page functions
> - do not add function beginning with two underscores
> - simplify bitflips counting for v1 controllers
> - Add ecc argument to mxc_nand_write_page()
> - drop unused oob_required argument from mxc_nand_write_page()
> 



-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com