From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Stefan Agner <stefan@agner.ch>
Cc: miquel.raynal@free-electrons.com,
boris.brezillon@free-electrons.com, computersforpeace@gmail.com,
dwmw2@infradead.org, marek.vasut@gmail.com,
cyrille.pitchen@wedev4u.fr, richard@nod.at,
bpringlemeir@gmail.com, marcel.ziswiler@toradex.com,
linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH v3 1/3] mtd: nand: vf610_nfc: remove unused function
Date: Mon, 12 Feb 2018 22:32:46 +0100 [thread overview]
Message-ID: <20180212223246.5e236413@bbrezillon> (raw)
In-Reply-To: <20180208235921.31840-2-stefan@agner.ch>
On Fri, 9 Feb 2018 00:59:19 +0100
Stefan Agner <stefan@agner.ch> wrote:
> The function count_written_bits has been replaced by the generic
> nand_check_erased_ecc_chunk() function with commit 48c25cf44118
> ("mtd: nand: vf610_nfc: use nand_check_erased_ecc_chunk() helper").
> Remove the unused function.
>
Applied.
Thanks,
Boris
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/mtd/nand/vf610_nfc.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
> index 80d31a58e558..2fa61cbdbaf7 100644
> --- a/drivers/mtd/nand/vf610_nfc.c
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -511,21 +511,6 @@ static void vf610_nfc_select_chip(struct mtd_info *mtd, int chip)
> vf610_nfc_write(nfc, NFC_ROW_ADDR, tmp);
> }
>
> -/* Count the number of 0's in buff up to max_bits */
> -static inline int count_written_bits(uint8_t *buff, int size, int max_bits)
> -{
> - uint32_t *buff32 = (uint32_t *)buff;
> - int k, written_bits = 0;
> -
> - for (k = 0; k < (size / 4); k++) {
> - written_bits += hweight32(~buff32[k]);
> - if (unlikely(written_bits > max_bits))
> - break;
> - }
> -
> - return written_bits;
> -}
> -
> static inline int vf610_nfc_correct_data(struct mtd_info *mtd, uint8_t *dat,
> uint8_t *oob, int page)
> {
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-02-12 21:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 23:59 [RFC PATCH v3 0/3] mtd: nand: vf610_nfc: make use of ->exec_op() Stefan Agner
2018-02-08 23:59 ` [RFC PATCH v3 1/3] mtd: nand: vf610_nfc: remove unused function Stefan Agner
2018-02-12 21:32 ` Boris Brezillon [this message]
2018-02-08 23:59 ` [RFC PATCH v3 2/3] mtd: nand: vf610_nfc: make use of ->exec_op() Stefan Agner
2018-02-09 8:20 ` Miquel Raynal
2018-02-09 12:41 ` Stefan Agner
2018-02-11 10:54 ` Boris Brezillon
2018-02-20 23:15 ` Stefan Agner
2018-02-20 23:34 ` Miquel Raynal
2018-02-21 7:18 ` Boris Brezillon
2018-02-21 8:30 ` Stefan Agner
2018-02-21 9:03 ` Boris Brezillon
2018-02-21 9:39 ` Stefan Agner
2018-02-21 10:09 ` Miquel Raynal
2018-02-21 12:32 ` Stefan Agner
2018-02-21 8:28 ` Boris Brezillon
2018-02-21 8:35 ` Boris Brezillon
2018-02-21 12:24 ` Stefan Agner
2018-02-21 12:46 ` Boris Brezillon
2018-02-21 21:18 ` Stefan Agner
2018-02-21 23:23 ` Stefan Agner
2018-02-22 9:13 ` Boris Brezillon
2018-02-08 23:59 ` [RFC PATCH v3 3/3] mtd: nand: vf610_nfc: remove old hooks Stefan Agner
2018-02-11 10:55 ` [RFC PATCH v3 0/3] mtd: nand: vf610_nfc: make use of ->exec_op() Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212223246.5e236413@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=bpringlemeir@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@free-electrons.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox