Re: [PATCH v2 0/2] Convert FSMC NAND controller driver to ->exec_op()

[Boris Brezillon <boris.brezillon@bootlin.com>]

On Fri, 16 Feb 2018 15:22:46 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hello,
> 
> Now that the ->exec_op() interface has been merged in the NAND core,
> convert the FSMC NAND controller driver to it.
> 
> A previous step involves getting rid of ->IO_ADDR_[R|W] across the
> driver, which is almost entirely done in the first patch. Because the
> driver still uses at that point the default implementations of
> ->read/write_byte/word(), some references are still present but are  
> removed as soon as the driver is moved to ->exec_op(), when this
> dependency disappears.
> 
> Best regards,
> Miquèl
> 
> 
> Changes since v1:
> =================
> 
> - Forgot about the NAND unique ID for now, this will need a deeper
>   rework of the MTD stack and is very (ONFI-)NAND-specific.
> - Split the migration of FSMC driver to ->exec_op() into two patches,
>   one to get rid of ->IO_ADDR_[R|W], the other to implement ->exec_op()
>   and ->select_chip() which is also needed.
> - Got rid of the additional ->regs entry in the FSMC structure, using
>   the existing entry ->regs_va instead.
> 
> 
> Miquel Raynal (2):
>   mtd: nand: fsmc: get rid of IO_ADDR_[R|W]
>   mtd: nand: fsmc: use ->exec_op()

Applied.

Thanks,

Boris

> 
>  drivers/mtd/nand/fsmc_nand.c | 242 ++++++++++++++++++++++++-------------------
>  1 file changed, 137 insertions(+), 105 deletions(-)
> 



-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com