From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: boris.brezillon@free-electrons.com, richard@nod.at,
dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr,
maximlevitsky@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, ezequiel@vanguardiasur.com.ar,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH NAND v4] mtd: nand: Replace printk() with appropriate pr_*() macro
Date: Thu, 22 Feb 2018 16:44:32 +0100 [thread overview]
Message-ID: <20180222164432.0f2b1e56@bbrezillon> (raw)
In-Reply-To: <1519313367-3360-1-git-send-email-shreeya.patel23498@gmail.com>
On Thu, 22 Feb 2018 20:59:27 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> The log levels embedded with the name are more concise than
> printk.
If you don't mind, I'll replace the above sentence by:
"
Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
"
The patch looks good otherwise, so I should apply it soon.
If you're okay, and Julia and Ezequiel are okay too, I'd like to move
to the next step and have you work on an ->exec_op() conversion
(jz4780?).
Of course, that does not prevent you from continuing the
printk()/dev_xx() conversion.
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-02-22 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 15:29 [PATCH NAND v4] mtd: nand: Replace printk() with appropriate pr_*() macro Shreeya Patel
2018-02-22 15:44 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222164432.0f2b1e56@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=maximlevitsky@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=richard@nod.at \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox