From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Stefan Agner <stefan@agner.ch>
Cc: miquel.raynal@free-electrons.com,
boris.brezillon@free-electrons.com, computersforpeace@gmail.com,
dwmw2@infradead.org, marek.vasut@gmail.com,
cyrille.pitchen@wedev4u.fr, richard@nod.at,
bpringle@sympatico.ca, marcel.ziswiler@toradex.com,
linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH v4 2/2] mtd: nand: vf610_nfc: remove old hooks
Date: Thu, 22 Feb 2018 23:14:56 +0100 [thread overview]
Message-ID: <20180222231456.102ec0da@bbrezillon> (raw)
In-Reply-To: <20180222202918.8708-3-stefan@agner.ch>
On Thu, 22 Feb 2018 21:29:18 +0100
Stefan Agner <stefan@agner.ch> wrote:
> @@ -1087,12 +838,6 @@ static int vf610_nfc_probe(struct platform_device *pdev)
> goto err_disable_clk;
> }
>
> - chip->dev_ready = vf610_nfc_dev_ready;
> - chip->cmdfunc = vf610_nfc_command;
> - chip->read_byte = vf610_nfc_read_byte;
> - chip->read_word = vf610_nfc_read_word;
> - chip->read_buf = vf610_nfc_read_buf;
> - chip->write_buf = vf610_nfc_write_buf;
> chip->exec_op = vf610_nfc_exec_op;
> chip->select_chip = vf610_nfc_select_chip;
> chip->onfi_set_features = nand_onfi_get_set_features_notsupp;
Your NAND controller should now support the SET/GET_FEATURES commands,
so you can remove the ->onfi_set/get_features assignment too (in a
separate patch, of course).
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-02-22 22:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 20:29 [RFC PATCH v4 0/2] mtd: nand: vf610_nfc: make use of ->exec_op() Stefan Agner
2018-02-22 20:29 ` [RFC PATCH v4 1/2] " Stefan Agner
2018-02-22 22:06 ` Boris Brezillon
2018-02-26 7:48 ` Stefan Agner
2018-02-26 20:05 ` Stefan Agner
2018-02-26 20:53 ` Boris Brezillon
2018-02-23 12:34 ` Miquel Raynal
2018-02-22 20:29 ` [RFC PATCH v4 2/2] mtd: nand: vf610_nfc: remove old hooks Stefan Agner
2018-02-22 22:14 ` Boris Brezillon [this message]
2018-02-22 21:00 ` [RFC PATCH v4 0/2] mtd: nand: vf610_nfc: make use of ->exec_op() Boris Brezillon
2018-02-22 22:24 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222231456.102ec0da@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=bpringle@sympatico.ca \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@free-electrons.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox