Re: [PATCH v5 1/3] mtd: nand: vf610_nfc: make use of ->exec_op()

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Stefan,

On Mon, 26 Feb 2018 22:18:53 +0100, Stefan Agner <stefan@agner.ch>
wrote:

> This reworks the driver to make use of ->exec_op() callback. The
> command sequencer of the VF610 NFC aligns well with the new ops
> interface.
> 
> The operations are translated to a NFC command code while filling
> the necessary registers. Instead of using the special status and
> read ID command codes (which require to read status/ID from
> special registers instead of the regular data area) the driver
> now now uses the main data buffer for all commands. This
> simplifies the driver as no special casing is needed.
> 
> For control data (status byte, id bytes and parameter page) the
> driver needs to reverse byte order for little endian CPUs since
> the controller seems to store the bytes in big endian order in
> the data buffer.
> 
> The current state seems to pass MTD tests on a Colibri VF61.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  drivers/mtd/nand/raw/vf610_nfc.c | 411 +++++++++++++++++++++++++++++++++++++--
>  1 file changed, 399 insertions(+), 12 deletions(-)

I am fine with this version.

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks for your work,
Miquèl

-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com