From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezHTP-0002np-5u for linux-mtd@lists.infradead.org; Fri, 23 Mar 2018 07:50:55 +0000 Date: Fri, 23 Mar 2018 08:50:37 +0100 From: Boris Brezillon To: Jagdish Gediya Cc: linux-mtd@lists.infradead.org, boris.brezillon@free-electrons.com, stable@vger.kernel.org, leoyang.li@nxp.com, oss@buserror.net, computersforpeace@gmail.com Subject: Re: [PATCH] mtd: rawnand: fsl_ifc: Read ECCSTAT0 and ECCSTAT1 registers for IFC 2.0 Message-ID: <20180323085037.04ce1041@bbrezillon> In-Reply-To: <1521661101-26911-1-git-send-email-jagdish.gediya@nxp.com> References: <1521661101-26911-1-git-send-email-jagdish.gediya@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 22 Mar 2018 01:08:10 +0530 Jagdish Gediya wrote: > Due to missing information in Hardware manual, current > implementation doesn't read ECCSTAT0 and ECCSTAT1 registers > for IFC 2.0. > > Add support to read ECCSTAT0 and ECCSTAT1 registers during > ecccheck for IFC 2.0. > > Fixes: 656441478ed5 ("mtd: nand: ifc: Fix location of eccstat > registers for IFC V1.0") > Cc: stable@vger.kernel.org # v3.18+ > Signed-off-by: Jagdish Gediya > Reviewed-by: Prabhakar Kushwaha Applied. Thanks, Boris > --- > drivers/mtd/nand/fsl_ifc_nand.c | 6 +----- > include/linux/fsl_ifc.h | 6 +----- > 2 files changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c > index ed64759..1513298 100644 > --- a/drivers/mtd/nand/fsl_ifc_nand.c > +++ b/drivers/mtd/nand/fsl_ifc_nand.c > @@ -227,11 +227,7 @@ static void fsl_ifc_run_command(struct mtd_info *mtd) > int sector_end = sector_start + chip->ecc.steps - 1; > __be32 *eccstat_regs; > > - if (ctrl->version >= FSL_IFC_VERSION_2_0_0) > - eccstat_regs = ifc->ifc_nand.v2_nand_eccstat; > - else > - eccstat_regs = ifc->ifc_nand.v1_nand_eccstat; > - > + eccstat_regs = ifc->ifc_nand.nand_eccstat; > eccstat = ifc_in32(&eccstat_regs[sector_start / 4]); > > for (i = sector_start; i <= sector_end; i++) { > diff --git a/include/linux/fsl_ifc.h b/include/linux/fsl_ifc.h > index c332f0a..3fdfede 100644 > --- a/include/linux/fsl_ifc.h > +++ b/include/linux/fsl_ifc.h > @@ -734,11 +734,7 @@ struct fsl_ifc_nand { > u32 res19[0x10]; > __be32 nand_fsr; > u32 res20; > - /* The V1 nand_eccstat is actually 4 words that overlaps the > - * V2 nand_eccstat. > - */ > - __be32 v1_nand_eccstat[2]; > - __be32 v2_nand_eccstat[6]; > + __be32 nand_eccstat[8]; > u32 res21[0x1c]; > __be32 nanndcr; > u32 res22[0x2]; -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com