From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 29 Mar 2018 22:24:09 +0200 From: Boris Brezillon To: Xiaolei Li Cc: , linux-mediatek@lists.infradead.org, linux-mtd@lists.infradead.org, srv_heupstream@mediatek.com Subject: Re: [PATCH v2 1/2] mtd: Fix some function description mismatches in mtdcore.c Message-ID: <20180329222409.325df4d0@bbrezillon> In-Reply-To: <1522287299-12620-2-git-send-email-xiaolei.li@mediatek.com> References: <1522287299-12620-1-git-send-email-xiaolei.li@mediatek.com> <1522287299-12620-2-git-send-email-xiaolei.li@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 29 Mar 2018 09:34:58 +0800 Xiaolei Li wrote: > In mtdcore.c, some function descriptions do not match function > definitions. Just fix these mismatches. > > Signed-off-by: Xiaolei Li Applied. Thanks, Boris > --- > drivers/mtd/mtdcore.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index 28553c8..413ea9b 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -419,7 +419,7 @@ int mtd_wunit_to_pairing_info(struct mtd_info *mtd, int wunit, > EXPORT_SYMBOL_GPL(mtd_wunit_to_pairing_info); > > /** > - * mtd_wunit_to_pairing_info - get wunit from pairing information > + * mtd_pairing_info_to_wunit - get wunit from pairing information > * @mtd: pointer to new MTD device info structure > * @info: pairing information struct > * > @@ -1525,9 +1525,9 @@ int mtd_ooblayout_get_databytes(struct mtd_info *mtd, u8 *databuf, > EXPORT_SYMBOL_GPL(mtd_ooblayout_get_databytes); > > /** > - * mtd_ooblayout_get_eccbytes - set data bytes into the oob buffer > + * mtd_ooblayout_set_databytes - set data bytes into the oob buffer > * @mtd: mtd info structure > - * @eccbuf: source buffer to get data bytes from > + * @databuf: source buffer to get data bytes from > * @oobbuf: OOB buffer > * @start: first ECC byte to set > * @nbytes: number of ECC bytes to set > @@ -1559,7 +1559,7 @@ int mtd_ooblayout_count_freebytes(struct mtd_info *mtd) > EXPORT_SYMBOL_GPL(mtd_ooblayout_count_freebytes); > > /** > - * mtd_ooblayout_count_freebytes - count the number of ECC bytes in OOB > + * mtd_ooblayout_count_eccbytes - count the number of ECC bytes in OOB > * @mtd: mtd info structure > * > * Works like mtd_ooblayout_count_bytes(), except it count ECC bytes. -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com