Re: [PATCH v2 04/10] spi: Extend the core to ease integration of SPI memory controllers

Boris Brezillon
2018-04-18T14:23:36Z

Hi Frieder,

On Mon, 16 Apr 2018 12:33:54 +0200
Frieder Schrempf <frieder.schrempf@exceet.de> wrote:

> > +
> > +/**
> > + * spi_mem_supports_op() - Check if a memory device and the controller it is
> > + * connected to support a specific memory operation
> > + * @mem: the SPI memory
> > + * @op: the memory operation to check
> > + *
> > + * Some controllers are only supporting Single or Dual IOs, others might only
> > + * support specific opcodes, or it can even be that the controller and device
> > + * both support Quad IOs but the hardware prevents you from using it because
> > + * only 2 IO lines are connected.
> > + *
> > + * This function checks whether a specific operation is supported.
> > + *
> > + * Return: true if @op is supported, false otherwise.
> > + */
> > +bool spi_mem_supports_op(struct spi_mem *mem, const struct spi_mem_op *op)
> > +{
> > + struct spi_controller *ctlr = mem->spi->controller;
> > +
> > + if (ctlr->mem_ops->supports_op)
>
> this misses a null check for mem_ops:
> if (ctlr->mem_ops && ctlr->mem_ops->supports_op)

Yep. I'll fix that in v3.

Thanks,

Boris