From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Xiaolei Li <xiaolei.li@mediatek.com>
Cc: <richard@nod.at>,
linux-mediatek@lists.infradead.org,
linux-mtd@lists.infradead.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH] mtd: Add sysfs attribute for mtd OOB available size
Date: Thu, 26 Apr 2018 20:04:32 +0200 [thread overview]
Message-ID: <20180426200432.7801e854@bbrezillon> (raw)
In-Reply-To: <1522657210-56833-2-git-send-email-xiaolei.li@mediatek.com>
On Mon, 2 Apr 2018 16:20:10 +0800
Xiaolei Li <xiaolei.li@mediatek.com> wrote:
> Expose mtd OOB available size by sysfs file. Then users can get available
> OOB size by accessing /sys/class/mtd/mtdX/oobavail.
>
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
Applied.
Thanks,
Boris
> ---
> Documentation/ABI/testing/sysfs-class-mtd | 8 ++++++++
> drivers/mtd/mtdcore.c | 10 ++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-mtd b/Documentation/ABI/testing/sysfs-class-mtd
> index f34e5923..3bc7c0a 100644
> --- a/Documentation/ABI/testing/sysfs-class-mtd
> +++ b/Documentation/ABI/testing/sysfs-class-mtd
> @@ -232,3 +232,11 @@ Description:
> of the parent (another partition or a flash device) in bytes.
> This attribute is absent on flash devices, so it can be used
> to distinguish them from partitions.
> +
> +What: /sys/class/mtd/mtdX/oobavail
> +Date: April 2018
> +KernelVersion: 4.16
> +Contact: linux-mtd@lists.infradead.org
> +Description:
> + Number of bytes available for a client to place data into
> + the out of band area.
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 807d17d..99d9352 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -210,6 +210,15 @@ static ssize_t mtd_oobsize_show(struct device *dev,
> }
> static DEVICE_ATTR(oobsize, S_IRUGO, mtd_oobsize_show, NULL);
>
> +static ssize_t mtd_oobavail_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct mtd_info *mtd = dev_get_drvdata(dev);
> +
> + return snprintf(buf, PAGE_SIZE, "%lu\n", (unsigned long)mtd->oobavail);
> +}
> +static DEVICE_ATTR(oobavail, S_IRUGO, mtd_oobavail_show, NULL);
> +
> static ssize_t mtd_numeraseregions_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> @@ -327,6 +336,7 @@ static ssize_t mtd_bbtblocks_show(struct device *dev,
> &dev_attr_writesize.attr,
> &dev_attr_subpagesize.attr,
> &dev_attr_oobsize.attr,
> + &dev_attr_oobavail.attr,
> &dev_attr_numeraseregions.attr,
> &dev_attr_name.attr,
> &dev_attr_ecc_strength.attr,
prev parent reply other threads:[~2018-04-26 18:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 8:20 [PATCH] Add sysfs attribute for mtd OOB available size Xiaolei Li
2018-04-02 8:20 ` [PATCH] mtd: " Xiaolei Li
2018-04-02 12:15 ` Boris Brezillon
2018-04-03 2:46 ` xiaolei li
2018-04-03 8:43 ` Boris Brezillon
2018-04-03 9:40 ` xiaolei li
2018-04-03 10:14 ` Boris Brezillon
2018-04-03 11:01 ` xiaolei li
2018-04-04 20:05 ` Boris Brezillon
2018-04-08 1:26 ` xiaolei li
2018-04-26 18:04 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426200432.7801e854@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=srv_heupstream@mediatek.com \
--cc=xiaolei.li@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox