From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 30 Apr 2018 12:09:30 +0200 From: Boris Brezillon To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , Russell King , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Tony Lindgren , Krzysztof Kozlowski , Bartosz Golaszewski , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect Message-ID: <20180430120930.4768a7cb@bbrezillon> In-Reply-To: <20180430082453.8091-1-brgl@bgdev.pl> References: <20180430082453.8091-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Bartosz, On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We have the 'ti,davinci-chipselect' property in the device tree, but > when using platform data the driver silently uses the id field of > struct platform_device as the chipselect. This is confusing and we > almost broke the nand support again recently after converting the > platform to common clock framework (which changed the device id in the > clock lookup - the problem is gone now that we no longer acquire the > clock in the nand driver. > > This series adds a new field to davinci-nand platform data, then makes > all board use it and finally modifies the two drivers that make use of > it. > > Bartosz Golaszewski (12): > mtd: nand: davinci: store the core chipselect number in platform data Raw NAND related patches (that is, everything that is not onenand or SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, I'm fine with the patch series, just let me know how you want to have it merged (through the MTD tree or the davinci tree). Thanks, Boris