From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Helmut Grohne <h.grohne@intenta.de>
Cc: Naga Sureshkumar Relli <nagasure@xilinx.com>,
linux-mtd@lists.infradead.org,
Boris Brezillon <Boris.Brezillon@bootlin.com>
Subject: Re: [LINUX, v8, 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface
Date: Thu, 3 May 2018 16:25:30 +0200 [thread overview]
Message-ID: <20180503162530.437f147a@xps13> (raw)
In-Reply-To: <20180503125600.vkv5vowdyjz5p2zt@laureti-dev>
Hi Naga,
On Thu, 3 May 2018 14:56:01 +0200, Helmut Grohne <h.grohne@intenta.de>
wrote:
> On Wed, Mar 14, 2018 at 04:18:25PM +0530, Naga Sureshkumar Relli wrote:
> > + xnand->row_addr_cycles = nand_chip->onfi_params.addr_cycles & 0xF;
> > + xnand->col_addr_cycles =
> > + (nand_chip->onfi_params.addr_cycles >> 4) & 0xF;
>
> Meanwhile onfi_params have been removed from the mainline and this patch
> no longer builds against v4.17-rc3. Can you resend a version that builds
> against with more recent kernels?
Actually I'm not sure you need addr_cycles from the ONFI param
page. What about non-ONFI chips? Anyway you won't find this entry
anymore as the param page is now freed after probe.
I don't get why you need this though?
Maybe you should have a look at the NAND_ROW_ADDR_3 flag?
Thanks,
Miquèl
>
> Helmut
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-03 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 10:48 [LINUX PATCH v8 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface nagasureshkumarrelli
2018-03-19 22:37 ` Miquel Raynal
2018-03-23 14:58 ` Naga Sureshkumar Relli
2018-03-26 21:53 ` Miquel Raynal
2018-03-27 4:02 ` Naga Sureshkumar Relli
[not found] ` <a84185e1-2f67-7d15-209d-bd70d31f0ea4@ni.com>
2018-04-22 15:17 ` Miquel Raynal
2018-04-24 10:18 ` Naga Sureshkumar Relli
2018-05-03 12:56 ` [LINUX, v8, " Helmut Grohne
2018-05-03 14:25 ` Miquel Raynal [this message]
2018-05-04 6:46 ` Naga Sureshkumar Relli
2018-05-17 13:24 ` Miquel Raynal
2018-05-18 7:33 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503162530.437f147a@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Boris.Brezillon@bootlin.com \
--cc=h.grohne@intenta.de \
--cc=linux-mtd@lists.infradead.org \
--cc=nagasure@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).