* [PATCH] mtd: cfi_cmdset_0002: Fix coding style issues
@ 2018-05-08 16:17 IKEGAMI Tokunori
2018-05-08 17:09 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: IKEGAMI Tokunori @ 2018-05-08 16:17 UTC (permalink / raw)
To: Boris Brezillon
Cc: Brian Norris, Boris Brezillon, Richard Weinberger, Marek Vasut,
PACKHAM Chris, linux-mtd@lists.infradead.org, Cyrille Pitchen,
David Woodhouse
From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/chips/cfi_cmdset_0002.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 56aa6b75213d..6f3619392506 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -207,7 +207,7 @@ static void fixup_use_write_buffers(struct mtd_info *mtd)
struct map_info *map = mtd->priv;
struct cfi_private *cfi = map->fldrv_priv;
if (cfi->cfiq->BufWriteTimeoutTyp) {
- pr_debug("Using buffer write method\n" );
+ pr_debug("Using buffer write method\n");
mtd->_write = cfi_amdstd_write_buffers;
}
}
@@ -1577,7 +1577,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
}
pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
- __func__, adr, datum.x[0] );
+ __func__, adr, datum.x[0]);
if (mode == FL_OTP_WRITE)
otp_enter(map, chip, adr, map_bankwidth(map));
@@ -1643,7 +1643,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
/* Did we succeed? */
if (!chip_good(map, adr, datum)) {
/* reset on all failures. */
- map_write( map, CMD(0xF0), chip->start );
+ map_write(map, CMD(0xF0), chip->start);
/* FIXME - should have reset delay before continuing */
if (++retry_cnt <= MAX_WORD_RETRIES)
@@ -1821,7 +1821,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
datum = map_word_load(map, buf);
pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
- __func__, adr, datum.x[0] );
+ __func__, adr, datum.x[0]);
XIP_INVAL_CACHED_RANGE(map, adr, len);
ENABLE_VPP(map);
@@ -2251,7 +2251,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
}
pr_debug("MTD %s(): ERASE 0x%.8lx\n",
- __func__, chip->start );
+ __func__, chip->start);
XIP_INVAL_CACHED_RANGE(map, adr, map->size);
ENABLE_VPP(map);
@@ -2297,7 +2297,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
if (time_after(jiffies, timeo)) {
printk(KERN_WARNING "MTD %s(): software timeout\n",
- __func__ );
+ __func__);
break;
}
@@ -2307,7 +2307,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
/* Did we succeed? */
if (!chip_good(map, adr, map_word_ff(map))) {
/* reset on all failures. */
- map_write( map, CMD(0xF0), chip->start );
+ map_write(map, CMD(0xF0), chip->start);
/* FIXME - should have reset delay before continuing */
ret = -EIO;
@@ -2340,7 +2340,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
}
pr_debug("MTD %s(): ERASE 0x%.8lx\n",
- __func__, adr );
+ __func__, adr);
XIP_INVAL_CACHED_RANGE(map, adr, len);
ENABLE_VPP(map);
@@ -2389,7 +2389,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
if (time_after(jiffies, timeo)) {
xip_enable(map, chip, adr);
printk(KERN_WARNING "MTD %s(): software timeout\n",
- __func__ );
+ __func__);
break;
}
@@ -2399,7 +2399,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
/* Did we succeed? */
if (!chip_good(map, adr, map_word_ff(map))) {
/* reset on all failures. */
- map_write( map, CMD(0xF0), chip->start );
+ map_write(map, CMD(0xF0), chip->start);
/* FIXME - should have reset delay before continuing */
ret = -EIO;
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: cfi_cmdset_0002: Fix coding style issues
2018-05-08 16:17 [PATCH] mtd: cfi_cmdset_0002: Fix coding style issues IKEGAMI Tokunori
@ 2018-05-08 17:09 ` Boris Brezillon
2018-05-08 17:22 ` IKEGAMI Tokunori
0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2018-05-08 17:09 UTC (permalink / raw)
To: IKEGAMI Tokunori
Cc: Brian Norris, Boris Brezillon, Richard Weinberger, Marek Vasut,
PACKHAM Chris, linux-mtd@lists.infradead.org, Cyrille Pitchen,
David Woodhouse
On Tue, 8 May 2018 16:17:59 +0000
IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:
> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Please add a commit message here saying which kind of coding stype
issues you're fixing (removal of unneeded spaces after '(' and before
')').
Also, I found [1] which you probably want to fix in this patch.
Thanks,
Boris
[1]https://elixir.bootlin.com/linux/v4.17-rc4/source/drivers/mtd/chips/cfi_cmdset_0002.c#L1566
>
> Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: linux-mtd@lists.infradead.org
> ---
> drivers/mtd/chips/cfi_cmdset_0002.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 56aa6b75213d..6f3619392506 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -207,7 +207,7 @@ static void fixup_use_write_buffers(struct mtd_info *mtd)
> struct map_info *map = mtd->priv;
> struct cfi_private *cfi = map->fldrv_priv;
> if (cfi->cfiq->BufWriteTimeoutTyp) {
> - pr_debug("Using buffer write method\n" );
> + pr_debug("Using buffer write method\n");
> mtd->_write = cfi_amdstd_write_buffers;
> }
> }
> @@ -1577,7 +1577,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
> }
>
> pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
> - __func__, adr, datum.x[0] );
> + __func__, adr, datum.x[0]);
>
> if (mode == FL_OTP_WRITE)
> otp_enter(map, chip, adr, map_bankwidth(map));
> @@ -1643,7 +1643,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
> /* Did we succeed? */
> if (!chip_good(map, adr, datum)) {
> /* reset on all failures. */
> - map_write( map, CMD(0xF0), chip->start );
> + map_write(map, CMD(0xF0), chip->start);
> /* FIXME - should have reset delay before continuing */
>
> if (++retry_cnt <= MAX_WORD_RETRIES)
> @@ -1821,7 +1821,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
> datum = map_word_load(map, buf);
>
> pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
> - __func__, adr, datum.x[0] );
> + __func__, adr, datum.x[0]);
>
> XIP_INVAL_CACHED_RANGE(map, adr, len);
> ENABLE_VPP(map);
> @@ -2251,7 +2251,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
> }
>
> pr_debug("MTD %s(): ERASE 0x%.8lx\n",
> - __func__, chip->start );
> + __func__, chip->start);
>
> XIP_INVAL_CACHED_RANGE(map, adr, map->size);
> ENABLE_VPP(map);
> @@ -2297,7 +2297,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
>
> if (time_after(jiffies, timeo)) {
> printk(KERN_WARNING "MTD %s(): software timeout\n",
> - __func__ );
> + __func__);
> break;
> }
>
> @@ -2307,7 +2307,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
> /* Did we succeed? */
> if (!chip_good(map, adr, map_word_ff(map))) {
> /* reset on all failures. */
> - map_write( map, CMD(0xF0), chip->start );
> + map_write(map, CMD(0xF0), chip->start);
> /* FIXME - should have reset delay before continuing */
>
> ret = -EIO;
> @@ -2340,7 +2340,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
> }
>
> pr_debug("MTD %s(): ERASE 0x%.8lx\n",
> - __func__, adr );
> + __func__, adr);
>
> XIP_INVAL_CACHED_RANGE(map, adr, len);
> ENABLE_VPP(map);
> @@ -2389,7 +2389,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
> if (time_after(jiffies, timeo)) {
> xip_enable(map, chip, adr);
> printk(KERN_WARNING "MTD %s(): software timeout\n",
> - __func__ );
> + __func__);
> break;
> }
>
> @@ -2399,7 +2399,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
> /* Did we succeed? */
> if (!chip_good(map, adr, map_word_ff(map))) {
> /* reset on all failures. */
> - map_write( map, CMD(0xF0), chip->start );
> + map_write(map, CMD(0xF0), chip->start);
> /* FIXME - should have reset delay before continuing */
>
> ret = -EIO;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mtd: cfi_cmdset_0002: Fix coding style issues
2018-05-08 17:09 ` Boris Brezillon
@ 2018-05-08 17:22 ` IKEGAMI Tokunori
2018-05-12 15:18 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: IKEGAMI Tokunori @ 2018-05-08 17:22 UTC (permalink / raw)
To: Boris Brezillon
Cc: Brian Norris, Boris Brezillon, Richard Weinberger, Marek Vasut,
PACKHAM Chris, linux-mtd@lists.infradead.org, Cyrille Pitchen,
David Woodhouse
From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
This patch fixes mainly to remove unneeded spaces after '(' and before ')'.
Also some indentation errors are fixed.
Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/chips/cfi_cmdset_0002.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 56aa6b75213d..e397b80e40cc 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -44,8 +44,8 @@
#define MAX_WORD_RETRIES 3
-#define SST49LF004B 0x0060
-#define SST49LF040B 0x0050
+#define SST49LF004B 0x0060
+#define SST49LF040B 0x0050
#define SST49LF008A 0x005a
#define AT49BV6416 0x00d6
@@ -207,7 +207,7 @@ static void fixup_use_write_buffers(struct mtd_info *mtd)
struct map_info *map = mtd->priv;
struct cfi_private *cfi = map->fldrv_priv;
if (cfi->cfiq->BufWriteTimeoutTyp) {
- pr_debug("Using buffer write method\n" );
+ pr_debug("Using buffer write method\n");
mtd->_write = cfi_amdstd_write_buffers;
}
}
@@ -1562,7 +1562,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
* depending of the conditions. The ' + 1' is to avoid having a
* timeout of 0 jiffies if HZ is smaller than 1000.
*/
- unsigned long uWriteTimeout = ( HZ / 1000 ) + 1;
+ unsigned long uWriteTimeout = (HZ / 1000) + 1;
int ret = 0;
map_word oldd;
int retry_cnt = 0;
@@ -1577,7 +1577,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
}
pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
- __func__, adr, datum.x[0] );
+ __func__, adr, datum.x[0]);
if (mode == FL_OTP_WRITE)
otp_enter(map, chip, adr, map_bankwidth(map));
@@ -1643,7 +1643,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
/* Did we succeed? */
if (!chip_good(map, adr, datum)) {
/* reset on all failures. */
- map_write( map, CMD(0xF0), chip->start );
+ map_write(map, CMD(0xF0), chip->start);
/* FIXME - should have reset delay before continuing */
if (++retry_cnt <= MAX_WORD_RETRIES)
@@ -1821,7 +1821,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
datum = map_word_load(map, buf);
pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
- __func__, adr, datum.x[0] );
+ __func__, adr, datum.x[0]);
XIP_INVAL_CACHED_RANGE(map, adr, len);
ENABLE_VPP(map);
@@ -2251,7 +2251,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
}
pr_debug("MTD %s(): ERASE 0x%.8lx\n",
- __func__, chip->start );
+ __func__, chip->start);
XIP_INVAL_CACHED_RANGE(map, adr, map->size);
ENABLE_VPP(map);
@@ -2297,7 +2297,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
if (time_after(jiffies, timeo)) {
printk(KERN_WARNING "MTD %s(): software timeout\n",
- __func__ );
+ __func__);
break;
}
@@ -2307,7 +2307,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
/* Did we succeed? */
if (!chip_good(map, adr, map_word_ff(map))) {
/* reset on all failures. */
- map_write( map, CMD(0xF0), chip->start );
+ map_write(map, CMD(0xF0), chip->start);
/* FIXME - should have reset delay before continuing */
ret = -EIO;
@@ -2340,7 +2340,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
}
pr_debug("MTD %s(): ERASE 0x%.8lx\n",
- __func__, adr );
+ __func__, adr);
XIP_INVAL_CACHED_RANGE(map, adr, len);
ENABLE_VPP(map);
@@ -2389,7 +2389,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
if (time_after(jiffies, timeo)) {
xip_enable(map, chip, adr);
printk(KERN_WARNING "MTD %s(): software timeout\n",
- __func__ );
+ __func__);
break;
}
@@ -2399,7 +2399,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
/* Did we succeed? */
if (!chip_good(map, adr, map_word_ff(map))) {
/* reset on all failures. */
- map_write( map, CMD(0xF0), chip->start );
+ map_write(map, CMD(0xF0), chip->start);
/* FIXME - should have reset delay before continuing */
ret = -EIO;
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: cfi_cmdset_0002: Fix coding style issues
2018-05-08 17:22 ` IKEGAMI Tokunori
@ 2018-05-12 15:18 ` Boris Brezillon
0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-05-12 15:18 UTC (permalink / raw)
To: IKEGAMI Tokunori
Cc: Boris Brezillon, Richard Weinberger, Marek Vasut, PACKHAM Chris,
linux-mtd@lists.infradead.org, Cyrille Pitchen, Brian Norris,
David Woodhouse
On Tue, 8 May 2018 17:22:28 +0000
IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:
> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
>
> This patch fixes mainly to remove unneeded spaces after '(' and before ')'.
> Also some indentation errors are fixed.
>
> Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: linux-mtd@lists.infradead.org
Applied.
Thanks,
Boris
> ---
> drivers/mtd/chips/cfi_cmdset_0002.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 56aa6b75213d..e397b80e40cc 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -44,8 +44,8 @@
>
> #define MAX_WORD_RETRIES 3
>
> -#define SST49LF004B 0x0060
> -#define SST49LF040B 0x0050
> +#define SST49LF004B 0x0060
> +#define SST49LF040B 0x0050
> #define SST49LF008A 0x005a
> #define AT49BV6416 0x00d6
>
> @@ -207,7 +207,7 @@ static void fixup_use_write_buffers(struct mtd_info *mtd)
> struct map_info *map = mtd->priv;
> struct cfi_private *cfi = map->fldrv_priv;
> if (cfi->cfiq->BufWriteTimeoutTyp) {
> - pr_debug("Using buffer write method\n" );
> + pr_debug("Using buffer write method\n");
> mtd->_write = cfi_amdstd_write_buffers;
> }
> }
> @@ -1562,7 +1562,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
> * depending of the conditions. The ' + 1' is to avoid having a
> * timeout of 0 jiffies if HZ is smaller than 1000.
> */
> - unsigned long uWriteTimeout = ( HZ / 1000 ) + 1;
> + unsigned long uWriteTimeout = (HZ / 1000) + 1;
> int ret = 0;
> map_word oldd;
> int retry_cnt = 0;
> @@ -1577,7 +1577,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
> }
>
> pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
> - __func__, adr, datum.x[0] );
> + __func__, adr, datum.x[0]);
>
> if (mode == FL_OTP_WRITE)
> otp_enter(map, chip, adr, map_bankwidth(map));
> @@ -1643,7 +1643,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip,
> /* Did we succeed? */
> if (!chip_good(map, adr, datum)) {
> /* reset on all failures. */
> - map_write( map, CMD(0xF0), chip->start );
> + map_write(map, CMD(0xF0), chip->start);
> /* FIXME - should have reset delay before continuing */
>
> if (++retry_cnt <= MAX_WORD_RETRIES)
> @@ -1821,7 +1821,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
> datum = map_word_load(map, buf);
>
> pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n",
> - __func__, adr, datum.x[0] );
> + __func__, adr, datum.x[0]);
>
> XIP_INVAL_CACHED_RANGE(map, adr, len);
> ENABLE_VPP(map);
> @@ -2251,7 +2251,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
> }
>
> pr_debug("MTD %s(): ERASE 0x%.8lx\n",
> - __func__, chip->start );
> + __func__, chip->start);
>
> XIP_INVAL_CACHED_RANGE(map, adr, map->size);
> ENABLE_VPP(map);
> @@ -2297,7 +2297,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
>
> if (time_after(jiffies, timeo)) {
> printk(KERN_WARNING "MTD %s(): software timeout\n",
> - __func__ );
> + __func__);
> break;
> }
>
> @@ -2307,7 +2307,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip)
> /* Did we succeed? */
> if (!chip_good(map, adr, map_word_ff(map))) {
> /* reset on all failures. */
> - map_write( map, CMD(0xF0), chip->start );
> + map_write(map, CMD(0xF0), chip->start);
> /* FIXME - should have reset delay before continuing */
>
> ret = -EIO;
> @@ -2340,7 +2340,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
> }
>
> pr_debug("MTD %s(): ERASE 0x%.8lx\n",
> - __func__, adr );
> + __func__, adr);
>
> XIP_INVAL_CACHED_RANGE(map, adr, len);
> ENABLE_VPP(map);
> @@ -2389,7 +2389,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
> if (time_after(jiffies, timeo)) {
> xip_enable(map, chip, adr);
> printk(KERN_WARNING "MTD %s(): software timeout\n",
> - __func__ );
> + __func__);
> break;
> }
>
> @@ -2399,7 +2399,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip,
> /* Did we succeed? */
> if (!chip_good(map, adr, map_word_ff(map))) {
> /* reset on all failures. */
> - map_write( map, CMD(0xF0), chip->start );
> + map_write(map, CMD(0xF0), chip->start);
> /* FIXME - should have reset delay before continuing */
>
> ret = -EIO;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-12 15:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-08 16:17 [PATCH] mtd: cfi_cmdset_0002: Fix coding style issues IKEGAMI Tokunori
2018-05-08 17:09 ` Boris Brezillon
2018-05-08 17:22 ` IKEGAMI Tokunori
2018-05-12 15:18 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).