From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fHWIh-0002Ox-SK for linux-mtd@lists.infradead.org; Sat, 12 May 2018 15:19:14 +0000 Date: Sat, 12 May 2018 17:18:59 +0200 From: Boris Brezillon To: IKEGAMI Tokunori Cc: Boris Brezillon , Richard Weinberger , Marek Vasut , PACKHAM Chris , "linux-mtd@lists.infradead.org" , Cyrille Pitchen , Brian Norris , David Woodhouse Subject: Re: [PATCH] mtd: cfi_cmdset_0002: Fix coding style issues Message-ID: <20180512171859.406d8d12@bbrezillon> In-Reply-To: References: <20180508190902.32c344b7@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 8 May 2018 17:22:28 +0000 IKEGAMI Tokunori wrote: > From: Tokunori Ikegami > > This patch fixes mainly to remove unneeded spaces after '(' and before ')'. > Also some indentation errors are fixed. > > Signed-off-by: Tokunori Ikegami > Cc: Chris Packham > Cc: Brian Norris > Cc: David Woodhouse > Cc: Boris Brezillon > Cc: Marek Vasut > Cc: Richard Weinberger > Cc: Cyrille Pitchen > Cc: linux-mtd@lists.infradead.org Applied. Thanks, Boris > --- > drivers/mtd/chips/cfi_cmdset_0002.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c > index 56aa6b75213d..e397b80e40cc 100644 > --- a/drivers/mtd/chips/cfi_cmdset_0002.c > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c > @@ -44,8 +44,8 @@ > > #define MAX_WORD_RETRIES 3 > > -#define SST49LF004B 0x0060 > -#define SST49LF040B 0x0050 > +#define SST49LF004B 0x0060 > +#define SST49LF040B 0x0050 > #define SST49LF008A 0x005a > #define AT49BV6416 0x00d6 > > @@ -207,7 +207,7 @@ static void fixup_use_write_buffers(struct mtd_info *mtd) > struct map_info *map = mtd->priv; > struct cfi_private *cfi = map->fldrv_priv; > if (cfi->cfiq->BufWriteTimeoutTyp) { > - pr_debug("Using buffer write method\n" ); > + pr_debug("Using buffer write method\n"); > mtd->_write = cfi_amdstd_write_buffers; > } > } > @@ -1562,7 +1562,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, > * depending of the conditions. The ' + 1' is to avoid having a > * timeout of 0 jiffies if HZ is smaller than 1000. > */ > - unsigned long uWriteTimeout = ( HZ / 1000 ) + 1; > + unsigned long uWriteTimeout = (HZ / 1000) + 1; > int ret = 0; > map_word oldd; > int retry_cnt = 0; > @@ -1577,7 +1577,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, > } > > pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n", > - __func__, adr, datum.x[0] ); > + __func__, adr, datum.x[0]); > > if (mode == FL_OTP_WRITE) > otp_enter(map, chip, adr, map_bankwidth(map)); > @@ -1643,7 +1643,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, > /* Did we succeed? */ > if (!chip_good(map, adr, datum)) { > /* reset on all failures. */ > - map_write( map, CMD(0xF0), chip->start ); > + map_write(map, CMD(0xF0), chip->start); > /* FIXME - should have reset delay before continuing */ > > if (++retry_cnt <= MAX_WORD_RETRIES) > @@ -1821,7 +1821,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, > datum = map_word_load(map, buf); > > pr_debug("MTD %s(): WRITE 0x%.8lx(0x%.8lx)\n", > - __func__, adr, datum.x[0] ); > + __func__, adr, datum.x[0]); > > XIP_INVAL_CACHED_RANGE(map, adr, len); > ENABLE_VPP(map); > @@ -2251,7 +2251,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) > } > > pr_debug("MTD %s(): ERASE 0x%.8lx\n", > - __func__, chip->start ); > + __func__, chip->start); > > XIP_INVAL_CACHED_RANGE(map, adr, map->size); > ENABLE_VPP(map); > @@ -2297,7 +2297,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) > > if (time_after(jiffies, timeo)) { > printk(KERN_WARNING "MTD %s(): software timeout\n", > - __func__ ); > + __func__); > break; > } > > @@ -2307,7 +2307,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) > /* Did we succeed? */ > if (!chip_good(map, adr, map_word_ff(map))) { > /* reset on all failures. */ > - map_write( map, CMD(0xF0), chip->start ); > + map_write(map, CMD(0xF0), chip->start); > /* FIXME - should have reset delay before continuing */ > > ret = -EIO; > @@ -2340,7 +2340,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, > } > > pr_debug("MTD %s(): ERASE 0x%.8lx\n", > - __func__, adr ); > + __func__, adr); > > XIP_INVAL_CACHED_RANGE(map, adr, len); > ENABLE_VPP(map); > @@ -2389,7 +2389,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, > if (time_after(jiffies, timeo)) { > xip_enable(map, chip, adr); > printk(KERN_WARNING "MTD %s(): software timeout\n", > - __func__ ); > + __func__); > break; > } > > @@ -2399,7 +2399,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, > /* Did we succeed? */ > if (!chip_good(map, adr, map_word_ff(map))) { > /* reset on all failures. */ > - map_write( map, CMD(0xF0), chip->start ); > + map_write(map, CMD(0xF0), chip->start); > /* FIXME - should have reset delay before continuing */ > > ret = -EIO;