From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIA2Q-00081q-CZ for linux-mtd@lists.infradead.org; Mon, 14 May 2018 09:45:04 +0000 Date: Mon, 14 May 2018 11:44:40 +0200 From: Boris Brezillon To: IKEGAMI Tokunori Cc: "boris.brezillon@free-electrons.com" , "marek.vasut@gmail.com" , "richard@nod.at" , Joakim Tjernlund , "PACKHAM Chris" , "linux-mtd@lists.infradead.org" , "cyrille.pitchen@wedev4u.fr" , "computersforpeace@gmail.com" , "dwmw2@infradead.org" Subject: Re: [PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase Message-ID: <20180514114440.54190a34@bbrezillon> In-Reply-To: References: <20180514091214.35ec45b8@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 14 May 2018 09:32:01 +0000 IKEGAMI Tokunori wrote: > Hi Boris-san, > > Thanks for your reviewing. > > > Can you please use git send-email when you send your patch series, so > > that they are properly threaded. > > Yes I have just resend the v5 patch series by using git send-email. > But the source address is set as smtpuser . > This is required on our company mail system currently. > But please do not reply to the address but reply to my email address below. > Tokunori Ikegami There's still a problem: the patches do not appear as a thread. Can you paste the git send-email command you use? > > Note: I am asking to resolve this issue to our IS department currently. > > I have just resend the patch series so please review the last patch series. > Very sorry for resending the patch series many times. It seems that nothing has changed, so nothing more to review on my side. And I'm still not entirely convinced by the fix, but if nobody complains, I'll apply it. BTW, the changelog is really not clear, you should have something like: Changes since v4: - blabla - blablabla Changes since v3: - blabla - blablabla Changes since v2: - blabla - blablabla Changes since v1: - blabla - blablabla